Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow predefined ACL names from either XML or JSON APIs. #1664

Merged
merged 1 commit into from Mar 28, 2016
Merged

Allow predefined ACL names from either XML or JSON APIs. #1664

merged 1 commit into from Mar 28, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 27, 2016

Convert names from the XML API to the equivalent JSON names.

Fixes #1659.

@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. labels Mar 27, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 27, 2016
dhermes
dhermes reviewed Mar 28, 2016
View reviewed changes
gcloud/storage/acl.py
@@ -409,7 +419,7 @@ def _save(self, acl, predefined, client):

:type predefined: string or None
:param predefined: An identifier for a predefined ACL. Must be one
of the keys in :attr:`_PREDEFINED_ACLS`
of the keys in :attr:`_PREDEFINED_JSON_ACLS`

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Mar 28, 2016

LGTM.

@tseaver
Allow predefined ACL names from either XML or JSON APIs.
f8f153d 
Convert names from the XML API to the equivalent JSON names.

Fixes #1659.
dhermes
dhermes reviewed Mar 28, 2016
View reviewed changes
gcloud/storage/acl.py
@@ -409,7 +419,7 @@ def _save(self, acl, predefined, client):

:type predefined: string or None
:param predefined: An identifier for a predefined ACL. Must be one
of the keys in :attr:`_PREDEFINED_ACLS`
of the keys in :attr:`PREDEFINED_JSON_ACLS`

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Mar 28, 2016

LGTM still

@tseaver tseaver merged commit 4ccb7a1 into googleapis:master Mar 28, 2016
@tseaver tseaver deleted the 1659-predefined_acl-support_json_spellings branch March 28, 2016 17:52
@dhermes dhermes mentioned this pull request Apr 1, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tseaver @dhermes @googlebot