Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add system test for 'Sink.reload'. #1678

Merged
merged 1 commit into from
Mar 30, 2016
Merged

Add system test for 'Sink.reload'. #1678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 17 additions & 3 deletions system_tests/logging_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def test_create_sink_storage_bucket(self):
self.to_delete.append(sink)
self.assertTrue(sink.exists())

def test_create_sink_bigquery_dataset(self):
def _init_bigquery_dataset(self):
from gcloud import bigquery
from gcloud.bigquery.dataset import AccessGrant
DATASET_URI = 'bigquery.googleapis.com/projects/%s/datasets/%s' % (
Expand All @@ -168,10 +168,24 @@ def test_create_sink_bigquery_dataset(self):
'WRITER', 'groupByEmail', 'cloud-logs@google.com'))
dataset.access_grants = grants
dataset.update()
return DATASET_URI

sink = Config.CLIENT.sink(
DEFAULT_SINK_NAME, DEFAULT_FILTER, DATASET_URI)
def test_create_sink_bigquery_dataset(self):
uri = self._init_bigquery_dataset()
sink = Config.CLIENT.sink(DEFAULT_SINK_NAME, DEFAULT_FILTER, uri)
self.assertFalse(sink.exists())
sink.create()
self.to_delete.append(sink)
self.assertTrue(sink.exists())

def test_reload_sink(self):
uri = self._init_bigquery_dataset()
sink = Config.CLIENT.sink(DEFAULT_SINK_NAME, DEFAULT_FILTER, uri)
self.assertFalse(sink.exists())
sink.create()
self.to_delete.append(sink)
sink.filter_ = 'BOGUS FILTER'
sink.destination = 'BOGUS DESTINATION'
sink.reload()
self.assertEqual(sink.filter_, DEFAULT_FILTER)
self.assertEqual(sink.destination, uri)