Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipping IAM system tests when running in emulator. #1748

Merged
merged 1 commit into from
Apr 27, 2016
Merged

Skipping IAM system tests when running in emulator. #1748

merged 1 commit into from
Apr 27, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Apr 23, 2016

/cc @hbchai

@dhermes dhermes added testing api: pubsub Issues related to the Pub/Sub API. labels Apr 23, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2016
tseaver
tseaver reviewed Apr 25, 2016
View reviewed changes
system_tests/pubsub.py
def _maybe_emulator_skip(self):
if os.getenv(PUBSUB_EMULATOR) is not None:
self.skipTest('IAM not supported by Pub/Sub emulator')

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor Author

dhermes commented Apr 27, 2016

@tseaver I had to rebase after #1745. Does this LGTY to merge? (Notice I added a comment in my _maybe_emulator_skip method.)

@tseaver
Copy link
Contributor

tseaver commented Apr 27, 2016

LGTM

@dhermes dhermes merged commit 6563cb7 into googleapis:master Apr 27, 2016
@dhermes dhermes deleted the pubsub-emulator-skip-iam branch April 27, 2016 23:50
@tseaver tseaver mentioned this pull request May 16, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tseaver tseaver

Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhermes @tseaver @googlebot