Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for Stackdriver Monitoring in the README. #2054

Merged
merged 1 commit into from
Aug 4, 2016
Merged

Add documentation for Stackdriver Monitoring in the README. #2054

merged 1 commit into from
Aug 4, 2016

Conversation

supriyagarg
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 4, 2016
dhermes
dhermes reviewed Aug 4, 2016
View reviewed changes
README.rst

.. code:: python

METRIC = 'compute.googleapis.com/instance/cpu/utilization'

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Aug 4, 2016

LGTM other than the constant var name for METRIC. Ping me after the change and I'll merge. Please squash the change into a single commit if it isn't too big a hassle (you can just change the file and then run a bare git commit --amend to fold into the original commit and then git push --force to overwrite the original commit)

@dhermes
Copy link
Contributor

dhermes commented Aug 4, 2016

Ah I just realized there are two commits already. Can you squash all into a single commit? (Sorry, doing code review from my phone)

@supriyagarg
Add documentation for Stackdriver Monitoring in the README.
77c4430 
Also, fix the README link for Google Stackdriver Logging.
@supriyagarg
Copy link
Contributor Author

Thanks. I made the edit and squashed the commits into one.

@dhermes dhermes merged commit 6749237 into googleapis:master Aug 4, 2016
@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@supriyagarg @dhermes @googlebot