Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slightly more explicit coverage for partition-related methods. #2060

Merged
merged 3 commits into from
Aug 9, 2016
Merged

Slightly more explicit coverage for partition-related methods. #2060

merged 3 commits into from
Aug 9, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 5, 2016

Follow-on to #2058.

@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Aug 5, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2016
@tseaver
Copy link
Contributor Author

tseaver commented Aug 8, 2016

@dhermes PTAL.

dhermes
dhermes reviewed Aug 8, 2016
View reviewed changes
gcloud/bigquery/table.py
@@ -245,25 +209,22 @@ def partitioning_type(self, value):
:type value: str
:param value: partitioning type only "DAY" is currently supported
"""
if not (isinstance(value, six.string_types)
and value.upper() == "DAY") and value is not None:
if value not in ['DAY', None]:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Aug 9, 2016

New changes LGTM. I wonder why types.NoneType is missing in Py3. Feel free to merge after fixing that attribute error. Squash if you can.

@dhermes
Copy link
Contributor

dhermes commented Aug 9, 2016

https://bugs.python.org/issue19438

@tseaver
Slightly more explicit coverage for partition-related methods.
c6333a3 
Follow-on to #2058.
@tseaver
Split 'SchemaField' out into its own module.
d4b6e13 
Reduces lines in 'test_table.py' to appease pylint's arbitrary ceiling.
@tseaver
Copy link
Contributor Author

tseaver commented Aug 9, 2016

I've rebased to master to get the tests fixed (after merging #2065). I will merge when Travis passes.

@dhermes
Copy link
Contributor

dhermes commented Aug 9, 2016

@tseaver FYI Travis has passed

@tseaver tseaver merged commit 4dbd7f9 into googleapis:master Aug 9, 2016
@tseaver tseaver deleted the bigquery-partition-tidy branch August 9, 2016 18:40
@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tseaver @dhermes @daspecster @googlebot