Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vision API connection. #2167

Merged
merged 1 commit into from
Aug 23, 2016
Merged

Add Vision API connection. #2167

merged 1 commit into from
Aug 23, 2016

Conversation

daspecster
Copy link
Contributor

As per a conversation about small PR's with @dhermes, here is Vision's connection class.

This is pretty simple, just adding the needed scope.

@daspecster daspecster added the api: vision Issues related to the Cloud Vision API. label Aug 23, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2016
@dhermes
Copy link
Contributor

dhermes commented Aug 23, 2016

Looks fine but Travis is failing.

dhermes
dhermes reviewed Aug 23, 2016
View reviewed changes
gcloud/vision/connection.py
API_VERSION = 'v1'
"""The version of the API, used in building the API call's URL."""

API_URL_TEMPLATE = '{api_base_url}/{api_version}{path}'

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@daspecster
Copy link
Contributor Author

It was failing, I believe because I didn't have the RST for it in there. Also I added an API URL example. https://vision.googleapis.com/v1/images:annotate

dhermes
dhermes reviewed Aug 23, 2016
View reviewed changes
scripts/generate_json_docs.py
@@ -629,7 +629,8 @@ def main():
'resource_manager': [],
'storage': [],
'streaming': [],
'translate': []
'translate': [],
'vision': []

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Aug 23, 2016

LGTM once Travis passes though you should squash if not too inconvenient

@dhermes dhermes mentioned this pull request Aug 23, 2016
Merged
@daspecster
Copy link
Contributor Author

Wow travis...what's the deal?

@tseaver
Copy link
Contributor

tseaver commented Aug 23, 2016

@daspecster I'm guessing the conflict is in docs/json/json/master/toc.json, after @dhermes merged #2171.

@dhermes
Copy link
Contributor

dhermes commented Aug 23, 2016

Yeah Travis has been slow. And in the 35 minutes since you posted that, I did give you a conflict. Sorry.

@daspecster
Add Vision API connection.
2cf3a90 
Add RST and ignore vision.__init__.

Add API URL example.

Add vision to TOCs.

Add trailing comma.

Add vision/connection to toc.json.
@dhermes dhermes mentioned this pull request Aug 23, 2016
Merged
@daspecster
Copy link
Contributor Author

Conflict resolved....back to waiting on travis.

@daspecster daspecster merged commit d64c9c3 into googleapis:master Aug 23, 2016
@daspecster
Copy link
Contributor Author

Finally!

@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
@daspecster daspecster deleted the vision-connection branch January 24, 2017 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tseaver tseaver

Labels
api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@daspecster @dhermes @tseaver @googlebot