Vision logo detection #2235
Merged
Vision logo detection #2235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
daspecster
added
the
do not merge
daspecster
force-pushed
the
vision-logo-detection
branch
2 times, most recently
from
5b20369
to
81cb07c
Compare
daspecster
force-pushed
the
vision-logo-detection
branch
3 times, most recently
from
7773a38
to
c404c65
Compare
daspecster
removed
the
do not merge
|
OK! @tseaver, I think this one is ready to go. |
|
|
||
|
|
||
| class EntityAnnotation(object): | ||
| """Representation of an entity returned from the Vision API.""" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
|
Awesome thanks! |
|
vercies -> vertices... |
daspecster
force-pushed
the
vision-logo-detection
branch
from
c49c675
to
028be63
Compare
daspecster
force-pushed
the
vision-logo-detection
branch
from
028be63
to
67ba8e5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off #2224.
This adds EntityAnnotation, which is used by LOGO_DETECTION, LANDMARK_DETECTION, LABEL_DETECTION and TEXT_DETECTION.
Small PRs for the other three detection types will follow.
✅
I'll rebase this after #2224 gets merged in.