Updating Pub / Sub GAX calls to work with emulator. #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@bjwatson It's worth checking out the "feature" I added to gRPC here (only the last commit of this applies, the rest are in the diffbase). May be worth sniffing for the emulator env. var. in the generated code? |
|
@dhermes needs rebasing. |
dhermes
force-pushed
the
fix-pubsub-emulator
branch
from
31e3369
to
ed4f325
Compare
|
ed4f325 LGTM |
dhermes
force-pushed
the
fix-pubsub-emulator
branch
from
ed4f325
to
b2f9169
Compare
In the process, removing the api_base_url from the Pub / Sub Connection class.
dhermes
force-pushed
the
fix-pubsub-emulator
branch
from
b2f9169
to
dd856df
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process, removing the
api_base_urlfrom the Pub / Sub Connection class.NOTE: Has #2244 as diffbase