Remove gRPC/GAX conditional checks.

[dhermes]

Adding support for an environment variable that App Engine users can use to disable installing gRPC packages into their application.

Follow-up to #2304.

@jonparrott Can you weigh in here on the GAE env. var. in setup.py?

[dhermes]

I also added this branch to https://github.com/GoogleCloudPlatform/google-cloud-python/ temporarily to vet the AppVeyor changes:
https://ci.appveyor.com/project/GoogleCloudPlatform/google-cloud-python/build/1.0.664.followup-2304

[theacodes]

What's prompting this change? This is essentially switching to grpc as a hard requirement for this library.

@omaray should probably chime in, too.

[dhermes]

@jonparrott I touched an old part in #2304 that sparked the discussion. gRPC is already a hard requirement in Python 2.7.

Very soon it won't be in google-cloud, it'll be in google-cloud-bigtable, google-cloud-pubsub, etc. so it's not that worrisome.

I just wanted your input on the env. var. to shut it down.

[theacodes]

Any dynamic behavior in setup.py will force you to stop providing wheels
(for py2.7 in this case, at least).

Otherwise whatever. App engine standard really just needs to add grpc
support and we probably need to write a custom script to handle installing
this package properly.

On Mon, Sep 12, 2016, 6:33 PM Danny Hermes notifications@github.com wrote:

@jonparrott https://github.com/jonparrott I touched an old part in #2304
#2304
that sparked the discussion. gRPC is already a hard requirement in Python
2.7.

Very soon it won't be in google-cloud, it'll be in google-cloud-bigtable,
google-cloud-pubsub, etc. so it's not that worrisome.

I just wanted your input on the env. var. to shut it down.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2308 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUcy8F66KFoXSbUqCRz2k-L_KfWWjiks5qpf17gaJpZM4J7G6R
.

[dhermes]

force you to stop providing wheels

How so?

[theacodes]

Wheels don't run setup.py at all.

On Mon, Sep 12, 2016, 6:40 PM Danny Hermes notifications@github.com wrote:

force you to stop providing wheels

How so?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2308 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUc76mbcgxFFGX-B3jZZqpJGrAs5Geks5qpf7_gaJpZM4J7G6R
.

[dhermes]

@jonparrott So your concern is that setup.py wouldn't be invoked by someone trying to install into a GAE environment?

---

Worth noting: I canceled the travis-ci/push check since it came from creating a branch. Though in reality I only created the branch for the AppVeyor check.

[theacodes]

@dhermes exactly

[dhermes]

But for the purposes of you writing docs, couldn't you include --no-use-wheel or --no-binary?

This discussion may become moot when we make each service it's own package? But for services like pubsub and logging, gRPC should be the default unless it can't be, so we'll probably add gRPC as a dependency in google-cloud-pubsub, etc.

Any suggestions for how to play nice with everyone (GAE, using wheels, etc.)?

[theacodes]

Just be sure to publish an sdist as well as a wheel for now. I really have no idea what our strategy is going to be for standard.

[dhermes]

@jonparrott SGTM, I'll tear out the env. var. and we can punt for now.

[dhermes]

I deleted the branch and AppVeyor didn't trigger on my new push w/o the GAE env. var.

https://ci.appveyor.com/project/GoogleCloudPlatform/google-cloud-python/build/1.0.664.followup-2304 still a good indicator that the changes work on Windows

[dhermes]

@tseaver PTAL

[tseaver]

I'm confused: aren't we losing our can't-install-gRPC fallback here?

[dhermes]

@tseaver What is our "our can't-install-gRPC fallback"?

[tseaver]

@dhermes Until this PR, installing gcloud-python without also installing gcloud-python[grpc] still allows use of all of the APIs except Bigtable. On platforms where those extras cannot be installed for some reason, the library is still useful: even Dubsub, Datastore, and Logging fall back to using HTTP.

With this change, users who cannot install grpcio and the GAX wrappers will no longer be able to install the library. GAE is the obvious case, but maybe users on older LTS releases will have the same issues.

[dhermes]

@tseaver

1. That's already not true on 2.7 (i.e. if they are on 2.7 we always add the gRPC deps, it is this way because Python 3 install was b0rked at the time)
2. Once we move to google-cloud-* packages, users can opt in to the packages they want, some of which will have gRPC and some which won't. Though for packages with a fallback, we still have to solve this problem.

[dhermes]

@tseaver Bump.

[tseaver]

LGTM. I'll let @jonparrott deal with the pitchfork-wielding GAE mob, then. :)