Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docs/requirements.txt to allow RTD local deps. #2444

Merged
merged 1 commit into from
Sep 27, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 27, 2016

Already updated the settings on RTD:

screen_shot_001

Followed the format suggested for pip: https://pip.pypa.io/en/latest/reference/pip_install/#requirements-file-format

@dhermes dhermes added the docs label Sep 27, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 27, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Sep 27, 2016

I'm going to merge pre-Travis since the only changed file has no impact on the build:

$ git ls-files | grep requirements
appveyor/requirements.txt
docs/requirements.txt
$ git grep requirements
CONTRIBUTING.rst:   >   --package=datastore --ignore-requirements
CONTRIBUTING.rst:   Sphinx and all development requirements in your virtualenv::
appveyor.yml:  - "%CMD_IN_ENV% pip install -r appveyor/requirements.txt"
system_tests/run_emulator.py:                         ignore_requirements=True)
system_tests/run_system_test.py:        '--ignore-requirements',
system_tests/run_system_test.py:        dest='ignore_requirements', action='store_true',
system_tests/run_system_test.py:def run_module_tests(module_name, ignore_requirements=False):
system_tests/run_system_test.py:    if not ignore_requirements:
system_tests/run_system_test.py:                         ignore_requirements=args.ignore_requirements)

I am jumping the gun on the merge because I'm not sure if RTD needs core/ or ../core/ as the path (or maybe neither will work, which would be sad).

@dhermes dhermes merged commit 5d56b8c into googleapis:master Sep 27, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Sep 27, 2016

Here is the build that was created: https://readthedocs.org/projects/google-cloud-python/builds/4447899/

@dhermes
Copy link
Contributor Author

dhermes commented Sep 27, 2016

  • Bad news: Build failed
  • Good news: It failed because bigquery was first and relies on core so changing the order should fix everything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants