Fix Timeseries Query in Monitoring System Test #2460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
supriyagarg
reviewed
Sep 28, 2016
| max_tries=MAX_RETRIES)(client.query) | ||
| return RetryErrors(BadRequest, max_tries=MAX_RETRIES)(retry_result) | ||
| endtime = datetime.datetime.utcnow() | ||
| endtime += datetime.timedelta(minutes=1) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
waprin
force-pushed
the
fix_timeseries_query
branch
from
9abf110
to
d5be4a0
Compare
added 2 commits
September 28, 2016 13:33
The old method was querying with the wrong interval, but the test still passed because new query objects were being unnecessarily created, and the end time would eventually roll over so the interval was correct. Besides being wrong, this also led to longer back off then necessary since results might have been available before the rollover.
dhermes
reviewed
Sep 29, 2016
| return len(list(result)) > 0 | ||
| # need to wrap built-in function for decorators to work | ||
| def list_timeseries(query): | ||
| return list(query) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
lukesneeringer
added
the
priority: p2
|
This issue may no longer be relevant due to its age. Feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2459 .
The old method was querying with the wrong interval, but the test still passed because new query objects were being unnecessarily created, and the end time would eventually roll over so the interval was correct. Besides being wrong, this also led to longer back off then necessary since results might have been available before the minute rollover.
This should be tweaked again if we decided to change
Queryobject to not replace seconds. But either way we definitely only want to create the Query object once and not retry it, and in the meantime this patch should speed up the system test.cc @supriyagarg @rimey