Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull in / reconcile all PRs for #314 #347

Merged
merged 24 commits into from
Nov 6, 2014
Merged

Pull in / reconcile all PRs for #314 #347

merged 24 commits into from
Nov 6, 2014

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 5, 2014

@tseaver
Add support for the Bucket's 'versioning' field.
d52d81f 
See: https://cloud.google.com/storage/docs/object-versioning

Addresses part of #314.
@tseaver
Add tests asserting that 'get_metatdata' raises w/ 'versioning'.
8477e85
@tseaver
Add support for the Bucket's 'logging' field.
037a732 
See: https://cloud.google.com/storage/docs/accesslogs

Addresses 'logging' part of #314.
@tseaver
Add CORS support to buckets.
c586a7c 
See: http://www.w3.org/TR/cors/ and
     https://cloud.google.com/storage/docs/json_api/v1/buckets

Addresses 'cors' part of 314.
@tseaver
Add location support to buckets.
b721f42 
See: https://cloud.google.com/storage/docs/json_api/v1/buckets and
https://cloud.google.com/storage/docs/concepts-techniques#specifyinglocations

Addresses 'location' part of 314.
@tseaver
Expanded / explicit coverage and assertions for '_helpers._MetadataMi…
c9fa1f3 
…xin'.
@tseaver
Remove redundant coverage for mixin methods.
2c3725d
@tseaver
Stop using 'metadata' to refer to all properties in bucket/key repres…
36966e8 
…etnation.

Make helper methods which get / set those properties private.

Split some dual-mode methods.
@tseaver
Wrap method / attr name in single quotes.
79e0b05
@tseaver
Add read-only properties for non-writable bucket fields.
7533899 
Addresses last part of #314.
@tseaver
Merge branch '314-bucket_versioning_support' into 314-omnibus
9d7fc2f
@tseaver
Merge branch '314-bucket_logging_support' into 314-omnibus
40c03c5
@tseaver
Merge branch '314-bucket_cors_support' into 314-omnibus
1fdacb4
@tseaver
Merge branch '314-bucket_location_support' into 314-omnibus
48677ee
@tseaver
Re-order methods to match field order.
c3fcb2e
@tseaver
Make 'lazy' test less eager.
aa7afbb
@tseaver
Fix up accessor / mutators methods to use new helpers.
5f1667a
@tseaver
Bucket has more fields than pylint wants to allow.
72f3e5a
@tseaver tseaver added api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Nov 5, 2014
This was referenced Nov 5, 2014
Closed
Closed
Closed
Closed
Closed
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 72f3e5a on tseaver:314-omnibus into 826ea69 on GoogleCloudPlatform:master.

dhermes
dhermes reviewed Nov 6, 2014
View reviewed changes
gcloud/storage/_helpers.py
:type name: string
:param name: The name of the object.

:type metadata: dict

This comment was marked as spam.

Sign in to view

tseaver added a commit that referenced this pull request Nov 6, 2014
@tseaver
Merge pull request #347 from tseaver/314-omnibus
4a8f6b4 
Pull in / reconcile all PRs for #314
@tseaver tseaver merged commit 4a8f6b4 into googleapis:master Nov 6, 2014
@tseaver tseaver deleted the 314-omnibus branch November 6, 2014 22:41
This was referenced Nov 6, 2014
Closed
Merged
tseaver added a commit that referenced this pull request Nov 6, 2014
@tseaver
Merge pull request #350 from tseaver/347-comment_change_lost_in_merge
ac0760b 
Re-do comment change lost in merge during #347.
This was referenced Nov 7, 2014
Closed
Closed
Closed
urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020
Account now has a connection constructor googleapis#347
9837efb
parthea pushed a commit that referenced this pull request Jun 4, 2023
@rsamborski
chore: code cleanup after snippets migration (#347)
5c35bf9
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.1.2 (#347)
1a73aeb
parthea added a commit that referenced this pull request Jun 4, 2023
@parthea
chore: Prepare for mono repository migration (#347)
268a865 
Remove replacement in owlbot.py which will be obsolete in the monorepo
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore: add prerelease nox session (#347)
39662f2 
Source-Link: googleapis/synthtool@d2871d9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:b2dc5f80edcf5d4486c39068c9fa11f7f851d9568eea4dcba130f994ea9b5e97

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Jul 6, 2023
@renovate-bot @parthea @gcf-owl-bot
chore(deps): update all dependencies (#347)
7a8b497 
* chore(deps): update all dependencies

* revert

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 20, 2023
@kchertenko
chore(samples): add comment about out-of-order requests (#347)
03a1ed2 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-retail/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@slowy07
docs: fix typos (#347)
79569e5
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@release-please
chore: release 2.7.1 (#349)
ca10f08 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.7.1](https://www.github.com/googleapis/python-dialogflow/compare/v2.7.0...v2.7.1) (2021-07-26)


### Bug Fixes

* enable self signed jwt for grpc ([#345](https://www.github.com/googleapis/python-dialogflow/issues/345)) ([ae434ed](https://www.github.com/googleapis/python-dialogflow/commit/ae434edc46c5e9c3243b928674727ea91cdf0145))


### Documentation

* fix typos ([#347](https://www.github.com/googleapis/python-dialogflow/issues/347)) ([1aa9a7a](https://www.github.com/googleapis/python-dialogflow/commit/1aa9a7a67d2997d87735666ecdcc55c8f8442cdf))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: Update gapic-generator-python to v1.8.4 (#347)
791b47b 
* chore: Update gapic-generator-python to v1.8.4

PiperOrigin-RevId: 507808936

Source-Link: googleapis/googleapis@64cf849

Source-Link: googleapis/googleapis-gen@53c48ca
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Sep 22, 2023
@release-please @parthea
chore(main): release 4.0.0 (#347)
2e2db22 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update all dependencies (#347)
ee9ed68
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): drop flake8-import-order in samples noxfile (#347)
a5ee583 
Source-Link: googleapis/synthtool@6ed3a83
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot @parthea
chore: use gapic-generator-python 0.58.4 (#347)
40a860a 
* chore: use gapic-generator-python 0.58.4

fix: provide appropriate mock values for message body fields

committer: dovs
PiperOrigin-RevId: 419025932

Source-Link: googleapis/googleapis@73da669

Source-Link: googleapis/googleapis-gen@46df624
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot @parthea
fix(deps): require protobuf >= 3.20.2 (#347)
4caa3e4 
* chore: exclude requirements.txt file from renovate-bot

Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7a40313731a7cb1454eef6b33d3446ebb121836738dc3ab3d2d3ded5268c35b6

* update constraints files

* fix(deps): require protobuf 3.20.2

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): drop flake8-import-order in samples noxfile (#347)
f816f7b 
Source-Link: googleapis/synthtool@6ed3a83
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot @parthea
fix(deps): require protobuf >= 3.20.2 (#347)
81f625c 
* chore: exclude requirements.txt file from renovate-bot

Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7a40313731a7cb1454eef6b33d3446ebb121836738dc3ab3d2d3ded5268c35b6

* update constraints files

* fix(deps): require protobuf 3.20.2

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): add nox session to sort python imports (#347)
d264893 
Source-Link: googleapis/synthtool@1b71c10
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:00c9d764fd1cd56265f12a5ef4b99a0c9e87cf261018099141e2ca5158890416

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
docs: Fix formatting of request arg in docstring (#347)
1176a90 
* docs: Fix formatting of request arg in docstring

chore: Update gapic-generator-python to v1.9.1
PiperOrigin-RevId: 518604533

Source-Link: googleapis/googleapis@8a085ae

Source-Link: googleapis/googleapis-gen@b2ab4b0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(deps): update actions/checkout action to v3 (#347)
36e3704 
Source-Link: googleapis/synthtool@ca87909
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6162c384d685c5fe22521d3f37f6fc732bf99a085f6d47b677dbcae97fc21392
parthea pushed a commit that referenced this pull request Oct 21, 2023
@release-please
chore(main): release 3.9.3 (#347)
92c68bc 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tseaver @coveralls @dhermes