Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten nox virtualenv names to avoid hashing. #3585

Merged
merged 1 commit into from
Jul 6, 2017
Merged

Shorten nox virtualenv names to avoid hashing. #3585

merged 1 commit into from
Jul 6, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 6, 2017

No description provided.

@tseaver tseaver added the testing label Jul 6, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 6, 2017
@dhermes
Copy link
Contributor

dhermes commented Jul 6, 2017

w00t! LGTM once CI goes green. (I also want to make sure CircleCI runs all the packages, which might keep it from going green, boo.)

/cc @jonparrott

@duggelz
Copy link

duggelz commented Jul 6, 2017

Just curious, since I use nox in another repo, can you explain what "avoid hashing" means here? What were the old dirnames and why were they bad?

@dhermes
Copy link
Contributor

dhermes commented Jul 6, 2017

@duggelz It'd be easier to just have @jonparrott explain, but I'll try. AFAIK, on Unix (or maybe just in Bash?) there is a limit on the length of a shebang line. So, when nox creates a directory /my/path/.nox/my-kind-of-long-test-name-param-3.1, it checks if the total length of that path is "too long". If it is "too long", then nox will automatically replace my-kind-of-long-test-name-param-3.1 with some shortened hash.

@tseaver tseaver merged commit bc7b0fd into googleapis:master Jul 6, 2017
@tseaver tseaver deleted the testing-set-nox-virtualenv-dirnames branch July 6, 2017 20:41
@theacodes
Copy link
Contributor

@dhermes is right, see pypa/pip#1773 and wntrblm/nox@b9a6af0

@dhermes dhermes mentioned this pull request Jul 14, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants