Add google.api.core.gapic_v1.method #4057

theacodes · 2017-09-25T20:00:11Z

Towards #3842.

core/google/api/core/gapic_v1/method.py

+    ``decorators`` may contain items that are ``None`` or ``False`` which will
+    be ignored.
+    """
+    decorators = list(filter(_is_not_none_or_false, decorators))


core/google/api/core/gapic_v1/method.py

+
+    # Merge this with any existing metric metadata.
+    client_metadata = ' '.join(filter(None, [
+        client_metadata, metadata.get(METRICS_METADATA_KEY, None)]))


core/google/api/core/gapic_v1/method.py

+            at all.
+
+    Returns:
+        TODO


core/google/api/core/gapic_v1/method.py

+        TODO
+    """
+    func = grpc_helpers.wrap_errors(func)
+    if metadata is not False:


core/google/api/core/gapic_v1/method.py

+    if metadata is not False:
+        metadata = _prepare_metadata(metadata)
+
+    def method(*args, **kwargs):


dhermes

Better, but still struggling a bit:

Why do we need to use False as a sentinel?
It seems the __call__ method could benefit from a helper that figures out the right timeout for the caller.

core/google/api/core/gapic_v1/method.py

+    ``decorators`` may contain items that are ``None`` or ``False`` which will
+    be ignored.
+    """
+    decorators = list(filter(_is_not_none_or_false, decorators))


core/google/api/core/gapic_v1/method.py

+
+    def __init__(self, target, retry, timeout, metadata):
+        """
+        Args:


core/google/api/core/gapic_v1/method.py

+                False, should accept a timeout argument. If metadata is not
+                False, it should accept a metadata argument.
+            retry (google.api.core.retry.Retry): The default retry for the
+                callable. If False, this callable will not retry.


core/google/api/core/gapic_v1/method.py

+        """Invoke the low-level RPC with retry, timeout, and metadata."""
+        # Note: Due to Python 2 lacking keyword-only arguments we use this
+        # pattern to extract the retry and timeout params.
+        retry_ = kwargs.pop('retry', None)


core/google/api/core/gapic_v1/method.py

+        # a non-default retry is specified, make sure the timeout's deadline
+        # matches the retry's. This handles the case where the user leaves
+        # the timeout default but specifies a lower deadline via the retry.
+        if (timeout_ is self._timeout


core/google/api/core/gapic_v1/method.py

+        # matches the retry's. This handles the case where the user leaves
+        # the timeout default but specifies a lower deadline via the retry.
+        if (timeout_ is self._timeout
+                and retry is not False


theacodes · 2017-09-26T17:08:36Z

Why do we need to use False as a sentinel?

At invocation time it indicates the difference between default and don't:

# Use default retry and timeout
wrapped_method()
# Don't retry
wrapped_method(retry=False)

It seems the __call__ method could benefit from a helper that figures out the right timeout for the caller.

Done.

theacodes · 2017-09-26T17:10:56Z

Why do we need to use False as a sentinel?

I suppose I could change

        retry = kwargs.pop('retry', None)
        if retry is None:
            retry = self._retry

to

    retry = kwargs.pop('retry', self._retry)

which means that wrapped_method(retry=False) and wrapped_method(retry=None) will be semantically equivalent.

Actually that makes sense, I'm gonna do that.

dhermes · 2017-09-26T17:11:24Z

At invocation time it indicates the difference between default and don't

I realize that's the use, I'm saying using False as the "don't" sentinel is confusing / problematic.

theacodes · 2017-09-26T17:12:09Z

metadata is going to keep the False sentinel, but I'll remove it from retry and timeout.

core/google/api/core/gapic_v1/method.py

@@ -82,9 +116,9 @@ class _GapicCallable(object):
            False, should accept a timeout argument. If metadata is not
            False, it should accept a metadata argument.
        retry (google.api.core.retry.Retry): The default retry for the
-            callable. If False, this callable will not retry.
+            callable. If falsy, this callable will not retry.


core/google/api/core/gapic_v1/method.py

-                and retry_ is not self._retry
-                and isinstance(timeout_, timeout.ExponentialTimeout)):
-            timeout_ = timeout_.with_deadline(retry_._deadline)
+        # Note: Due to Python 2 lacking keyword-only arguments we kwargs to


core/google/api/core/gapic_v1/method.py

+            # a different retry.
+            kwargs.get('retry', None))
+
+        retry = kwargs.pop('retry', None)


core/google/api/core/gapic_v1/method.py

+            # Use the invocation-specified retry only for this, as we only
+            # want to adjust the timeout deadline if the *user* specified
+            # a different retry.
+            kwargs.get('retry', None))


core/google/api/core/gapic_v1/method.py

+            a timeout argument to the low-level RPC method by default.
+        metadata (Optional[Sequence[Tuple[str, str]]]): gRPC call metadata
+            that's passed to the low-level RPC method. If falsy, no metadata
+            will be passed to the low-level RPC method.


core/google/api/core/gapic_v1/method.py

@@ -133,32 +131,32 @@ def __init__(self, target, retry, timeout, metadata):

    def __call__(self, *args, **kwargs):
        """Invoke the low-level RPC with retry, timeout, and metadata."""
-        # Note: Due to Python 2 lacking keyword-only arguments we kwargs to
+        # Note: Due to Python 2 lacking keyword-only arguments we use kwargs to


core/google/api/core/gapic_v1/method.py


        # Apply all applicable decorators.
        wrapped_func = _apply_decorators(self._target, [retry, timeout_])

        # Set the metadata for the call using the metadata calculated by
        # _prepare_metadata.
-        if self._metadata is not False:
+        if self._metadata:


core/google/api/core/gapic_v1/method.py

-            metadata. If ``False``, metadata will not be passed to the function
-            at all.
+            metadata. If ``None``, metadata will not be passed to the function
+            at all, if ``USE_DEFAULT_METADATA`` (the default) then only the


core/google/api/core/gapic_v1/method.py

+def _apply_decorators(func, decorators):
+    """Apply a list of decorators to a given function.
+
+    ``decorators`` may contain items that are ``None`` or ``False`` which will


core/google/api/core/gapic_v1/method.py

+        metadata = {}
+
+    if metadata is not None:
+        metadata = _prepare_metadata(metadata)


core/google/api/core/gapic_v1/method.py

+        # a non-default retry is specified, make sure the timeout's deadline
+        # matches the retry's. This handles the case where the user leaves
+        # the timeout default but specifies a lower deadline via the retry.
+        if retry and isinstance(default_timeout, timeout.ExponentialTimeout):


core/google/api/core/gapic_v1/method.py

+        # matches the retry's. This handles the case where the user leaves
+        # the timeout default but specifies a lower deadline via the retry.
+        if retry and isinstance(default_timeout, timeout.ExponentialTimeout):
+            return default_timeout.with_deadline(retry._deadline)


core/google/api/core/gapic_v1/method.py

+            arguments and applies the common error mapping, retry, timeout,
+            and metadata behavior to the low-level RPC method.
+    """
+    func = grpc_helpers.wrap_errors(func)


dhermes

LGTM

…CloudPlatform/python-docs-samples#4057) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [google-api-python-client](https://togithub.com/googleapis/google-api-python-client) | patch | `==1.9.2` -> `==1.9.3` | --- ### Release Notes <details> <summary>googleapis/google-api-python-client</summary> ### [`v1.9.3`](https://togithub.com/googleapis/google-api-python-client/blob/master/CHANGELOG.md#193-httpswwwgithubcomgoogleapisgoogle-api-python-clientcomparev192v193-2020-06-10) [Compare Source](https://togithub.com/googleapis/google-api-python-client/compare/v1.9.2...v1.9.3) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples).

@flaky

* Add Monitoring v3 Samples Refactor v2 samples in to separate directory Add v3 Samples Renamed auth to list_env * Update requirements * Fix metric.name All the filters should be metric.type (API change, name is now the fully qualified REST resource). * Monitoring Doc Fixups * Use Main Project (now whitelisted) * Fix minor typo in custom_metric.py * Mark Monitoring As Flaky * Updating requirements. Change-Id: I95c7ddfe77430a2800d09e329f23ba8b2b939be2 * Don’t send name in create custom metric * updating requirements [(#358)](GoogleCloudPlatform/python-docs-samples#358) Change-Id: I6177a17fad021e26ed76679d9db34848c17b62a8 * Update Reqs * Fix flaky custom metric test. Change-Id: Ia2628f205537099d28415412fe302763f17c3081 * Update requirements. [(#436)](GoogleCloudPlatform/python-docs-samples#436) * Remove output only fields [(#454)](GoogleCloudPlatform/python-docs-samples#454) * Auto-update dependencies. [(#459)](GoogleCloudPlatform/python-docs-samples#459) * Fix import order lint errors Change-Id: Ieaf7237fc6f925daec46a07d2e81a452b841198a * bump Change-Id: I02e7767d13ba267ee9fc72c5b68a57013bb8b8d3 * Auto-update dependencies. [(#470)](GoogleCloudPlatform/python-docs-samples#470) * Auto-update dependencies. [(#476)](GoogleCloudPlatform/python-docs-samples#476) * Auto-update dependencies. [(#486)](GoogleCloudPlatform/python-docs-samples#486) * Stackdriver product rename [(#508)](GoogleCloudPlatform/python-docs-samples#508) * Auto-update dependencies. [(#537)](GoogleCloudPlatform/python-docs-samples#537) * Fix lint issues Change-Id: I0af78055cf33393a737f44acea2ba14555f494e1 * Fix monitoring test Change-Id: I31c4dc368617996bc5b95c1414a39b9d45e11ebe * Auto-update dependencies. [(#584)](GoogleCloudPlatform/python-docs-samples#584) * Generate readmes for most service samples [(#599)](GoogleCloudPlatform/python-docs-samples#599) * Auto-update dependencies. [(#609)](GoogleCloudPlatform/python-docs-samples#609) * Auto-update dependencies. [(#625)](GoogleCloudPlatform/python-docs-samples#625) * Auto-update dependencies. [(#629)](GoogleCloudPlatform/python-docs-samples#629) * Auto-update dependencies. [(#735)](GoogleCloudPlatform/python-docs-samples#735) * Auto-update dependencies. * Fix language OCR sample * Remove unused import * Add region tags for writing time series [(#757)](GoogleCloudPlatform/python-docs-samples#757) * Auto-update dependencies. [(#762)](GoogleCloudPlatform/python-docs-samples#762) * Cleanup metric descriptors [(#776)](GoogleCloudPlatform/python-docs-samples#776) * Auto-update dependencies. [(#783)](GoogleCloudPlatform/python-docs-samples#783) * Auto-update dependencies. [(#785)](GoogleCloudPlatform/python-docs-samples#785) * Auto-update dependencies. [(#790)](GoogleCloudPlatform/python-docs-samples#790) * Add Monitoring Google Cloud Samples [(#789)](GoogleCloudPlatform/python-docs-samples#789) * Add Monitoring Google Cloud Samples * jon wayne review * fixups * Fix tests * jonwayne * Auto-update dependencies. [(#794)](GoogleCloudPlatform/python-docs-samples#794) * Monitoring Region Tags [(#796)](GoogleCloudPlatform/python-docs-samples#796) * Add get metric descriptor [(#797)](GoogleCloudPlatform/python-docs-samples#797) * Fix mon reginos [(#798)](GoogleCloudPlatform/python-docs-samples#798) * Fix monitoring tests [(#799)](GoogleCloudPlatform/python-docs-samples#799) * Fix monitoring tests * Fixing monitoring tests Change-Id: I9e5d2a1143381430cc790085f90e210f9495d630 * Remove usage of GoogleCredentials [(#810)](GoogleCloudPlatform/python-docs-samples#810) * Update monitoring region tags [(#830)](GoogleCloudPlatform/python-docs-samples#830) * Remove cloud config fixture [(#887)](GoogleCloudPlatform/python-docs-samples#887) * Remove cloud config fixture * Fix client secrets * Fix bigtable instance * Remove resource [(#890)](GoogleCloudPlatform/python-docs-samples#890) * Remove resource fixture * Remove remote resource * De-flake metric test * Fix lint issues * Fix reference to our testing tools * Auto-update dependencies. [(#914)](GoogleCloudPlatform/python-docs-samples#914) * Auto-update dependencies. * xfail the error reporting test * Fix lint * Re-generate all readmes * Fix README rst links [(#962)](GoogleCloudPlatform/python-docs-samples#962) * Fix README rst links * Update all READMEs * Auto-update dependencies. [(#1004)](GoogleCloudPlatform/python-docs-samples#1004) * Auto-update dependencies. * Fix natural language samples * Fix pubsub iam samples * Fix language samples * Fix bigquery samples * Auto-update dependencies. [(#1055)](GoogleCloudPlatform/python-docs-samples#1055) * Auto-update dependencies. * Explicitly use latest bigtable client Change-Id: Id71e9e768f020730e4ca9514a0d7ebaa794e7d9e * Revert language update for now Change-Id: I8867f154e9a5aae00d0047c9caf880e5e8f50c53 * Remove pdb. smh Change-Id: I5ff905fadc026eebbcd45512d4e76e003e3b2b43 * Update monitoring samples to use more descriptive variable names [(#1058)](GoogleCloudPlatform/python-docs-samples#1058) Change-Id: I648cd686a10399b7f92373fdcd48708396fd7140 * Auto-update dependencies. [(#1093)](GoogleCloudPlatform/python-docs-samples#1093) * Auto-update dependencies. * Fix storage notification poll sample Change-Id: I6afbc79d15e050531555e4c8e51066996717a0f3 * Fix spanner samples Change-Id: I40069222c60d57e8f3d3878167591af9130895cb * Drop coverage because it's not useful Change-Id: Iae399a7083d7866c3c7b9162d0de244fbff8b522 * Try again to fix flaky logging test Change-Id: I6225c074701970c17c426677ef1935bb6d7e36b4 * Auto-update dependencies. [(#1094)](GoogleCloudPlatform/python-docs-samples#1094) * Auto-update dependencies. * Relax assertions in the ocr_nl sample Change-Id: I6d37e5846a8d6dd52429cb30d501f448c52cbba1 * Drop unused logging apiary samples Change-Id: I545718283773cb729a5e0def8a76ebfa40829d51 * Update all generated readme auth instructions [(#1121)](GoogleCloudPlatform/python-docs-samples#1121) Change-Id: I03b5eaef8b17ac3dc3c0339fd2c7447bd3e11bd2 * Auto-update dependencies. [(#1133)](GoogleCloudPlatform/python-docs-samples#1133) * Auto-update dependencies. * Fix missing http library Change-Id: I99faa600f2f3f1f50f57694fc9835d7f35bda250 * Added Link to Python Setup Guide [(#1158)](GoogleCloudPlatform/python-docs-samples#1158) * Update Readme.rst to add Python setup guide As requested in b/64770713. This sample is linked in documentation https://cloud.google.com/bigtable/docs/scaling, and it would make more sense to update the guide here than in the documentation. * Update README.rst * Update README.rst * Update README.rst * Update README.rst * Update README.rst * Update install_deps.tmpl.rst * Updated readmegen scripts and re-generated related README files * Fixed the lint error * Auto-update dependencies. [(#1186)](GoogleCloudPlatform/python-docs-samples#1186) * Auto-update dependencies. [(#1217)](GoogleCloudPlatform/python-docs-samples#1217) * Added "Open in Cloud Shell" buttons to README files [(#1254)](GoogleCloudPlatform/python-docs-samples#1254) * Auto-update dependencies. [(#1309)](GoogleCloudPlatform/python-docs-samples#1309) * Auto-update dependencies. [(#1320)](GoogleCloudPlatform/python-docs-samples#1320) * Auto-update dependencies. [(#1355)](GoogleCloudPlatform/python-docs-samples#1355) * Auto-update dependencies. [(#1359)](GoogleCloudPlatform/python-docs-samples#1359) * Auto-update dependencies. [(#1377)](GoogleCloudPlatform/python-docs-samples#1377) * Auto-update dependencies. * Update requirements.txt * Fix client instantiation [(#1396)](GoogleCloudPlatform/python-docs-samples#1396) * Auto-update dependencies. * Regenerate the README files and fix the Open in Cloud Shell link for some samples [(#1441)](GoogleCloudPlatform/python-docs-samples#1441) * Update READMEs to fix numbering and add git clone [(#1464)](GoogleCloudPlatform/python-docs-samples#1464) * Fix monitoring region tags. [(#1472)](GoogleCloudPlatform/python-docs-samples#1472) * Sample's for stackdriver's uptime check api. [(#1478)](GoogleCloudPlatform/python-docs-samples#1478) * Sample's for stackdriver's uptime check api. * Add doc tags. * Stackdriver monitoring alerts sample. [(#1475)](GoogleCloudPlatform/python-docs-samples#1475) * Stackdriver monitoring alerts sample. * Lint * py27 tests pass * Accomodate reviewer's comments. * Add spaces around code blocks, Inc => LLC, and add docstring. * Reformat doc comments to look like Google doc comments. * Add more doc tags to alerts sample. [(#1483)](GoogleCloudPlatform/python-docs-samples#1483) * Add more doc tags to alerts sample. * lint * Update monitoring samples to use version 0.29.0 of the client library. [(#1495)](GoogleCloudPlatform/python-docs-samples#1495) * Update monitoring samples to use version 0.29.0 of the client library. * Fix typo. * Add sample to update a cloud monitoring uptime check. [(#1508)](GoogleCloudPlatform/python-docs-samples#1508) * Add sample to update a cloud monitoring uptime check. * Replace double quotes with single quotes. * Auto-update dependencies. [(#1658)](GoogleCloudPlatform/python-docs-samples#1658) * Auto-update dependencies. * Rollback appengine/standard/bigquery/. * Rollback appengine/standard/iap/. * Rollback bigtable/metricscaler. * Rolledback appengine/flexible/datastore. * Rollback dataproc/ * Rollback jobs/api_client * Rollback vision/cloud-client. * Rollback functions/ocr/app. * Rollback iot/api-client/end_to_end_example. * Rollback storage/cloud-client. * Rollback kms/api-client. * Rollback dlp/ * Rollback bigquery/cloud-client. * Rollback iot/api-client/manager. * Rollback appengine/flexible/cloudsql_postgresql. * Time series tests use random unique name to avoid limits [(#1776)](GoogleCloudPlatform/python-docs-samples#1776) * Time series tests use random unique name to avoid limits * Lint wants another blank line here * Use current debian image family * Restore to old state. Work should be on different branch. * Update snippets.py * Added new region tag [(#1844)](GoogleCloudPlatform/python-docs-samples#1844) * Auto-update dependencies. [(#1846)](GoogleCloudPlatform/python-docs-samples#1846) ACK, merging. * New snippet to delete notification channel [(#1920)](GoogleCloudPlatform/python-docs-samples#1920) New snippet to delete notification channel * Auto-update dependencies. [(#1980)](GoogleCloudPlatform/python-docs-samples#1980) * Auto-update dependencies. * Update requirements.txt * Update requirements.txt * monitoring/metrics: update from 5 to 20 minutes [(#2210)](GoogleCloudPlatform/python-docs-samples#2210) * Make backup/restore file name a parameter [(#2248)](GoogleCloudPlatform/python-docs-samples#2248) * Make backup/restore file a parameter Previously was hard coded as 'backup.json' * Added parameter to test function calls * Adds split updates for Firebase ... opencensus [(#2438)](GoogleCloudPlatform/python-docs-samples#2438) * Auto-update dependencies. [(#2005)](GoogleCloudPlatform/python-docs-samples#2005) * Auto-update dependencies. * Revert update of appengine/flexible/datastore. * revert update of appengine/flexible/scipy * revert update of bigquery/bqml * revert update of bigquery/cloud-client * revert update of bigquery/datalab-migration * revert update of bigtable/quickstart * revert update of compute/api * revert update of container_registry/container_analysis * revert update of dataflow/run_template * revert update of datastore/cloud-ndb * revert update of dialogflow/cloud-client * revert update of dlp * revert update of functions/imagemagick * revert update of functions/ocr/app * revert update of healthcare/api-client/fhir * revert update of iam/api-client * revert update of iot/api-client/gcs_file_to_device * revert update of iot/api-client/mqtt_example * revert update of language/automl * revert update of run/image-processing * revert update of vision/automl * revert update testing/requirements.txt * revert update of vision/cloud-client/detect * revert update of vision/cloud-client/product_search * revert update of jobs/v2/api_client * revert update of jobs/v3/api_client * revert update of opencensus * revert update of translate/cloud-client * revert update to speech/cloud-client Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com> Co-authored-by: Doug Mahugh <dmahugh@gmail.com> * fix: monitoring tests [(#2995)](GoogleCloudPlatform/python-docs-samples#2995) * fix: monitoring tests * Add eventually consistent to flaky test * chore(deps): update dependency google-auth to v1.11.2 [(#2724)](GoogleCloudPlatform/python-docs-samples#2724) Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com> * Simplify noxfile setup. [(#2806)](GoogleCloudPlatform/python-docs-samples#2806) * chore(deps): update dependency requests to v2.23.0 * Simplify noxfile and add version control. * Configure appengine/standard to only test Python 2.7. * Update Kokokro configs to match noxfile. * Add requirements-test to each folder. * Remove Py2 versions from everything execept appengine/standard. * Remove conftest.py. * Remove appengine/standard/conftest.py * Remove 'no-sucess-flaky-report' from pytest.ini. * Add GAE SDK back to appengine/standard tests. * Fix typo. * Roll pytest to python 2 version. * Add a bunch of testing requirements. * Remove typo. * Add appengine lib directory back in. * Add some additional requirements. * Fix issue with flake8 args. * Even more requirements. * Readd appengine conftest.py. * Add a few more requirements. * Even more Appengine requirements. * Add webtest for appengine/standard/mailgun. * Add some additional requirements. * Add workaround for issue with mailjet-rest. * Add responses for appengine/standard/mailjet. Co-authored-by: Renovate Bot <bot@renovateapp.com> * [monitoring] fix: use retrying module in the fixture class [(#3285)](GoogleCloudPlatform/python-docs-samples#3285) * fix: use retrying module in the fixture class fixes #2971 fixes #2972 fixes #2973 fixes #3085 It will likely fix those issues, not guaranteed, but it's worth a try. * [monitoring] testing: mitigate 409 conflicts [(#3311)](GoogleCloudPlatform/python-docs-samples#3311) * [monitoring] testing: mitigate 409 conflicts fixes #2971 * retry on ServiceUnavailable too * reduce the number of api calls * mark tests as flaky instead of having retries * fix the rerun_filter implementation * add randomness to the sleep calls * lonter wait, better teardown * allow both messages * switch to regular flaky in monitoring [(#3333)](GoogleCloudPlatform/python-docs-samples#3333) * switch to regular flaky * minor assertion adjustment * address nit * Update dependency tabulate to v0.8.7 [(#3202)](GoogleCloudPlatform/python-docs-samples#3202) Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com> The error is a known error that does not have to do with this dependency change * Update dependency google-auth to v1.14.0 [(#3148)](GoogleCloudPlatform/python-docs-samples#3148) Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com> * chore(deps): update dependency google-api-python-client to v1.8.0 [(#3100)](GoogleCloudPlatform/python-docs-samples#3100) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [google-api-python-client](https://togithub.com/google/google-api-python-client) | minor | `==1.7.11` -> `==1.8.0` | --- ### Release Notes <details> <summary>google/google-api-python-client</summary> ### [`v1.8.0`](https://togithub.com/google/google-api-python-client/releases/v1.8.0) [Compare Source](https://togithub.com/google/google-api-python-client/compare/v1.7.12...v1.8.0) Release to support API endpoint override. New Features - Add api endpoint override. ([#829](https://togithub.com/googleapis/google-api-python-client/pull/829)) Implementation Changes - Don't set http.redirect_codes if the attr doesn't exist and allow more httplib2 versions. ([#841](https://togithub.com/googleapis/google-api-python-client/pull/841)) ### [`v1.7.12`](https://togithub.com/google/google-api-python-client/releases/v1.7.12) [Compare Source](https://togithub.com/google/google-api-python-client/compare/v1.7.11...v1.7.12) Bugfix release Implementation Changes - Look for field 'detail' in error message. ([#739](https://togithub.com/googleapis/google-api-python-client/pull/739)) - Exclude 308s from httplib2 redirect codes list ([#813](https://togithub.com/googleapis/google-api-python-client/pull/813)) Documentation - Remove oauth2client from docs ([#738](https://togithub.com/googleapis/google-api-python-client/pull/738)) - Fix typo. ([#745](https://togithub.com/googleapis/google-api-python-client/pull/745)) - Remove compatibility badges. ([#746](https://togithub.com/googleapis/google-api-python-client/pull/746)) - Fix TypeError: search_analytics_api_sample.py [#732](https://togithub.com/google/google-api-python-client/issues/732) ([#742](https://togithub.com/googleapis/google-api-python-client/pull/742)) - Correct response access ([#750](https://togithub.com/googleapis/google-api-python-client/pull/750)) - Fix link to API explorer ([#760](https://togithub.com/googleapis/google-api-python-client/pull/760)) - Fix argument typo in oauth2 code example ([#763](https://togithub.com/googleapis/google-api-python-client/pull/763)) - Recommend install with virtualenv ([#768](https://togithub.com/googleapis/google-api-python-client/pull/768)) - Fix capitalization in docs/README.md ([#770](https://togithub.com/googleapis/google-api-python-client/pull/770)) - Remove compatibility badges ([#796](https://togithub.com/googleapis/google-api-python-client/pull/796)) - Remove mentions of pycrypto ([#799](https://togithub.com/googleapis/google-api-python-client/pull/799)) - Fix typo in model.py - Add note about Google Ads llibrary ([#814](https://togithub.com/googleapis/google-api-python-client/pull/814)) Internal / Testing Changes - Blacken ([#772](https://togithub.com/googleapis/google-api-python-client/pull/722)) - Move kokoro configs ([#832](https://togithub.com/googleapis/google-api-python-client/pull/832)) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples). * chore(deps): update dependency google-cloud-monitoring to v0.35.0 [(#3459)](GoogleCloudPlatform/python-docs-samples#3459) Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com> * [monitoring] chore: remove gcp-devrel-py-tools [(#3480)](GoogleCloudPlatform/python-docs-samples#3480) * [monitoring] chore: remove gcp-devrel-py-tools * fixed the infinite loop * fix 404 error * Update dependency google-api-python-client to v1.8.2 [(#3452)](GoogleCloudPlatform/python-docs-samples#3452) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [google-api-python-client](https://togithub.com/google/google-api-python-client) | patch | `==1.8.0` -> `==1.8.2` | | [google-api-python-client](https://togithub.com/google/google-api-python-client) | minor | `==1.7.11` -> `==1.8.2` | --- ### Release Notes <details> <summary>google/google-api-python-client</summary> ### [`v1.8.2`](https://togithub.com/google/google-api-python-client/blob/master/CHANGELOG.md#182-httpswwwgithubcomgoogleapisgoogle-api-python-clientcomparev181v182-2020-04-21) [Compare Source](https://togithub.com/google/google-api-python-client/compare/v1.8.1...v1.8.2) ### [`v1.8.1`](https://togithub.com/google/google-api-python-client/blob/master/CHANGELOG.md#181-httpswwwgithubcomgoogleapisgoogle-api-python-clientcomparev180v181-2020-04-20) [Compare Source](https://togithub.com/google/google-api-python-client/compare/v1.8.0...v1.8.1) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples). * testing: replace @flaky with @pytest.mark.flaky [(#3496)](GoogleCloudPlatform/python-docs-samples#3496) * testing: replace @flaky with @pytest.mark.flaky * lint * mark few tests as flaky that involves LRO polling. * lint * chore(deps): update dependency google-auth to v1.14.1 [(#3464)](GoogleCloudPlatform/python-docs-samples#3464) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [google-auth](https://togithub.com/googleapis/google-auth-library-python) | patch | `==1.14.0` -> `==1.14.1` | | [google-auth](https://togithub.com/googleapis/google-auth-library-python) | minor | `==1.11.2` -> `==1.14.1` | --- ### Release Notes <details> <summary>googleapis/google-auth-library-python</summary> ### [`v1.14.1`](https://togithub.com/googleapis/google-auth-library-python/blob/master/CHANGELOG.md#1141-httpswwwgithubcomgoogleapisgoogle-auth-library-pythoncomparev1140v1141-2020-04-21) [Compare Source](https://togithub.com/googleapis/google-auth-library-python/compare/v1.14.0...v1.14.1) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples). * [monitoring] fix: use backoff for writing the value [(#3697)](GoogleCloudPlatform/python-docs-samples#3697) * [monitoring] fix: use backoff for writing the value fixes #3694 * use uuid * chore(deps): update dependency google-auth to v1.14.2 [(#3724)](GoogleCloudPlatform/python-docs-samples#3724) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [google-auth](https://togithub.com/googleapis/google-auth-library-python) | patch | `==1.14.1` -> `==1.14.2` | --- ### Release Notes <details> <summary>googleapis/google-auth-library-python</summary> ### [`v1.14.2`](https://togithub.com/googleapis/google-auth-library-python/blob/master/CHANGELOG.md#1142-httpswwwgithubcomgoogleapisgoogle-auth-library-pythoncomparev1141v1142-2020-05-07) [Compare Source](https://togithub.com/googleapis/google-auth-library-python/compare/v1.14.1...v1.14.2) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples). * chore: some lint fixes [(#3748)](GoogleCloudPlatform/python-docs-samples#3748) * chore(deps): update dependency google-auth to v1.14.3 [(#3728)](GoogleCloudPlatform/python-docs-samples#3728) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [google-auth](https://togithub.com/googleapis/google-auth-library-python) | patch | `==1.14.2` -> `==1.14.3` | --- ### Release Notes <details> <summary>googleapis/google-auth-library-python</summary> ### [`v1.14.3`](https://togithub.com/googleapis/google-auth-library-python/blob/master/CHANGELOG.md#1143-httpswwwgithubcomgoogleapisgoogle-auth-library-pythoncomparev1142v1143-2020-05-11) [Compare Source](https://togithub.com/googleapis/google-auth-library-python/compare/v1.14.2...v1.14.3) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [x] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples). * Add request_method to create example. [(#3745)](GoogleCloudPlatform/python-docs-samples#3745) Co-authored-by: Takashi Matsuo <tmatsuo@google.com> * testing: multi project noxfile-template.py [(#3700)](GoogleCloudPlatform/python-docs-samples#3700) * testing: prototpe for multi project noxfile.py * correct project names * introduce TEST_CONFIG * modify noxfile-template, add default config * changed how we import user config * fix stale comments * use different project for python 3.6 and 3.7 * fix a bug * changed the filename also simplified the config stop runnint `gcloud update` add a warning about editing noxfile.py * add BUILD_SPECIFIC_GCLOUD_PROJECT * use session.skip * print debuggin * more print debuggin * adding cwd to sys.path * removed debug print, display details of ImportError * use the usual test project * stop setting gcloud project * simplified the noxfile-template * [monitoring] testing: start using build specific projects [(#3771)](GoogleCloudPlatform/python-docs-samples#3771) Also added `required_api_url` and `required_role` field in `README.rst.in`. A part of #3310 Note: Now the service account has permission only on the project for py36 build, so py37 build should fail. * chore(deps): update dependency google-cloud-monitoring to v0.36.0 [(#3783)](GoogleCloudPlatform/python-docs-samples#3783) Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com> * update google-auth to 1.15.0 final part [(#3819)](GoogleCloudPlatform/python-docs-samples#3819) * update google-api-python-client to 1.8.3 final part [(#3827)](GoogleCloudPlatform/python-docs-samples#3827) * chore(deps): update dependency google-api-python-client to v1.8.4 [(#3881)](GoogleCloudPlatform/python-docs-samples#3881) Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com> * [monitoring] fix: use the same random value for retry [(#3900)](GoogleCloudPlatform/python-docs-samples#3900) * [monitoring] fix: use the same random value for retry fixes #3875 * Just reseed in `write_value()` * revert comment * chore(deps): update dependency google-auth to v1.16.0 [(#3903)](GoogleCloudPlatform/python-docs-samples#3903) * chore(deps): update dependency google-api-python-client to v1.9.1 [(#3930)](GoogleCloudPlatform/python-docs-samples#3930) * chore(deps): update dependency google-cloud-monitoring to v1 [(#3950)](GoogleCloudPlatform/python-docs-samples#3950) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [google-cloud-monitoring](https://togithub.com/googleapis/python-monitoring) | major | `==0.36.0` -> `==1.0.0` | --- ### Release Notes <details> <summary>googleapis/python-monitoring</summary> ### [`v1.0.0`](https://togithub.com/googleapis/python-monitoring/blob/master/CHANGELOG.md#100-httpswwwgithubcomgoogleapispython-monitoringcomparev0360v100-2020-06-03) [Compare Source](https://togithub.com/googleapis/python-monitoring/compare/v0.36.0...v1.0.0) ##### Features - set release_status to Production/Stable ([#8](https://www.github.com/googleapis/python-monitoring/issues/8)) ([a99d67a](https://www.github.com/googleapis/python-monitoring/commit/a99d67a4f1399b9a74f189c6332cd85e56149fac)) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples). * final update for google-auth [(#3967)](GoogleCloudPlatform/python-docs-samples#3967) * testing: start using btlr [(#3959)](GoogleCloudPlatform/python-docs-samples#3959) * testing: start using btlr The binary is at gs://cloud-devrel-kokoro-resources/btlr/v0.0.1/btlr * add period after DIFF_FROM * use array for btlr args * fix websocket tests * add debug message * wait longer for the server to spin up * dlp: bump the wait timeout to 10 minutes * [run] copy noxfile.py to child directory to avoid gcloud issue * [iam] fix: only display description when the key exists * use uuid4 instead of uuid1 * [iot] testing: use the same format for registry id * Stop asserting Out of memory not in the output * fix missing imports * [dns] testing: more retries with delay * [dlp] testing: longer timeout * use the max-concurrency flag * use 30 workers * [monitoring] use multiple projects * [dlp] testing: longer timeout * Replace GCLOUD_PROJECT with GOOGLE_CLOUD_PROJECT. [(#4022)](GoogleCloudPlatform/python-docs-samples#4022) * Update dependency google-api-python-client to v1.9.2 [(#4038)](GoogleCloudPlatform/python-docs-samples#4038) * Update dependency google-auth to v1.17.0 [(#4058)](GoogleCloudPlatform/python-docs-samples#4058) * chore(deps): update dependency google-auth to v1.17.1 [(#4073)](GoogleCloudPlatform/python-docs-samples#4073) * Update dependency google-auth to v1.17.2 [(#4083)](GoogleCloudPlatform/python-docs-samples#4083) * Update dependency google-api-python-client to v1.9.3 [(#4057)](GoogleCloudPlatform/python-docs-samples#4057) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [google-api-python-client](https://togithub.com/googleapis/google-api-python-client) | patch | `==1.9.2` -> `==1.9.3` | --- ### Release Notes <details> <summary>googleapis/google-api-python-client</summary> ### [`v1.9.3`](https://togithub.com/googleapis/google-api-python-client/blob/master/CHANGELOG.md#193-httpswwwgithubcomgoogleapisgoogle-api-python-clientcomparev192v193-2020-06-10) [Compare Source](https://togithub.com/googleapis/google-api-python-client/compare/v1.9.2...v1.9.3) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples). * Update dependency google-auth to v1.18.0 [(#4125)](GoogleCloudPlatform/python-docs-samples#4125) * [monitoring] fix: mitigate flake [(#4153)](GoogleCloudPlatform/python-docs-samples#4153) fixes #4150 * fix(monitoring): also retry upon DeadlineExceeded [(#4202)](GoogleCloudPlatform/python-docs-samples#4202) fixes #4180 Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> * Create example for POST check. [(#4082)](GoogleCloudPlatform/python-docs-samples#4082) * Add create example for POST check. * Small fixes for POST check stuff. * Have create example be one tag block * Syntax fixes * Small fixes. * Ran black linter. Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com> * Update dependency google-auth-httplib2 to v0.0.4 [(#4255)](GoogleCloudPlatform/python-docs-samples#4255) Co-authored-by: Takashi Matsuo <tmatsuo@google.com> * chore(deps): pin dependencies [(#4280)](GoogleCloudPlatform/python-docs-samples#4280) * chore(deps): pin dependencies * specify python version for appengine standard Co-authored-by: Leah Cole <coleleah@google.com> * chore(deps): update dependency pytest to v5.4.3 [(#4279)](GoogleCloudPlatform/python-docs-samples#4279) * chore(deps): update dependency pytest to v5.4.3 * specify pytest for python 2 in appengine Co-authored-by: Leah Cole <coleleah@google.com> * chore(deps): update dependency mock to v4 [(#4287)](GoogleCloudPlatform/python-docs-samples#4287) * chore(deps): update dependency mock to v4 * specify mock version for appengine python 2 Co-authored-by: Leah Cole <coleleah@google.com> * chore(deps): update dependency google-auth to v1.19.0 [(#4293)](GoogleCloudPlatform/python-docs-samples#4293) * Update dependency flaky to v3.7.0 [(#4300)](GoogleCloudPlatform/python-docs-samples#4300) * Update dependency google-api-python-client to v1.10.0 [(#4302)](GoogleCloudPlatform/python-docs-samples#4302) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [google-api-python-client](https://togithub.com/googleapis/google-api-python-client) | minor | `==1.9.3` -> `==1.10.0` | --- ### Release Notes <details> <summary>googleapis/google-api-python-client</summary> ### [`v1.10.0`](https://togithub.com/googleapis/google-api-python-client/blob/master/CHANGELOG.md#1100-httpswwwgithubcomgoogleapisgoogle-api-python-clientcomparev193v1100-2020-07-15) [Compare Source](https://togithub.com/googleapis/google-api-python-client/compare/v1.9.3...v1.10.0) ##### Features - allow to use 'six.moves.collections_abc.Mapping' in 'client_options.from_dict()' ([#943](https://www.github.com/googleapis/google-api-python-client/issues/943)) ([21af37b](https://www.github.com/googleapis/google-api-python-client/commit/21af37b11ea2d6a89b3df484e1b2fa1d12849510)) - Build universal wheels ([#948](https://www.github.com/googleapis/google-api-python-client/issues/948)) ([3e28a1e](https://www.github.com/googleapis/google-api-python-client/commit/3e28a1e0d47f829182cd92f37475ab91fa5e4afc)) - discovery supports retries ([#967](https://www.github.com/googleapis/google-api-python-client/issues/967)) ([f3348f9](https://www.github.com/googleapis/google-api-python-client/commit/f3348f98bf91a88a28bf61b12b95e391cc3be1ff)), closes [#848](https://www.github.com/googleapis/google-api-python-client/issues/848) ##### Documentation - consolidating and updating the Contribution Guide ([#964](https://www.github.com/googleapis/google-api-python-client/issues/964)) ([63f97f3](https://www.github.com/googleapis/google-api-python-client/commit/63f97f37daee37a725eb05df3097b20d5d4eaaf0)), closes [#963](https://www.github.com/googleapis/google-api-python-client/issues/963) ##### [1.9.3](https://www.github.com/googleapis/google-api-python-client/compare/v1.9.2...v1.9.3) (2020-06-10) ##### Bug Fixes - update GOOGLE_API_USE_MTLS values ([#940](https://www.github.com/googleapis/google-api-python-client/issues/940)) ([19908ed](https://www.github.com/googleapis/google-api-python-client/commit/19908edcd8a3df1db41e34100acc1f15c3c99397)) ##### [1.9.2](https://www.github.com/googleapis/google-api-python-client/compare/v1.9.1...v1.9.2) (2020-06-04) ##### Bug Fixes - bump api-core version ([#936](https://www.github.com/googleapis/google-api-python-client/issues/936)) ([ee53b3b](https://www.github.com/googleapis/google-api-python-client/commit/ee53b3b32a050874ba4cfb491fb384f94682c824)) ##### [1.9.1](https://www.github.com/googleapis/google-api-python-client/compare/v1.9.0...v1.9.1) (2020-06-02) ##### Bug Fixes - fix python-api-core dependency issue ([#931](https://www.github.com/googleapis/google-api-python-client/issues/931)) ([42028ed](https://www.github.com/googleapis/google-api-python-client/commit/42028ed2b2be47f85b70eb813185264f1f573d01)) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples). * chore(deps): update dependency google-auth to v1.19.1 [(#4304)](GoogleCloudPlatform/python-docs-samples#4304) * chore(deps): update dependency google-auth to v1.19.2 [(#4321)](GoogleCloudPlatform/python-docs-samples#4321) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [google-auth](https://togithub.com/googleapis/google-auth-library-python) | patch | `==1.19.1` -> `==1.19.2` | --- ### Release Notes <details> <summary>googleapis/google-auth-library-python</summary> ### [`v1.19.2`](https://togithub.com/googleapis/google-auth-library-python/blob/master/CHANGELOG.md#1192-httpswwwgithubcomgoogleapisgoogle-auth-library-pythoncomparev1191v1192-2020-07-17) [Compare Source](https://togithub.com/googleapis/google-auth-library-python/compare/v1.19.1...v1.19.2) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples). * Update dependency google-auth to v1.20.0 [(#4387)](GoogleCloudPlatform/python-docs-samples#4387) * Update dependency pytest to v6 [(#4390)](GoogleCloudPlatform/python-docs-samples#4390) * chore(deps): update dependency google-auth to v1.20.1 [(#4452)](GoogleCloudPlatform/python-docs-samples#4452) * chore(deps): update dependency google-api-python-client to v1.10.1 [(#4557)](GoogleCloudPlatform/python-docs-samples#4557) * chore(deps): update dependency google-api-python-client to v1.10.1 * Update requirements.txt Co-authored-by: Takashi Matsuo <tmatsuo@google.com> * chore(deps): update dependency google-cloud-monitoring to v1.1.0 [(#4561)](GoogleCloudPlatform/python-docs-samples#4561) * Update dependency google-auth to v1.21.0 [(#4588)](GoogleCloudPlatform/python-docs-samples#4588) * Update dependency google-api-python-client to v1.11.0 [(#4587)](GoogleCloudPlatform/python-docs-samples#4587) Co-authored-by: Takashi Matsuo <tmatsuo@google.com> * chore(deps): update dependency google-auth to v1.21.1 [(#4634)](GoogleCloudPlatform/python-docs-samples#4634) * chore(deps): update dependency google-auth to v1.21.2 [(#4684)](GoogleCloudPlatform/python-docs-samples#4684) * fix(monitoring): retry in the test setup [(#4702)](GoogleCloudPlatform/python-docs-samples#4702) fixes #4687 fixes #4688 fixes #4689 fixes #4690 * chore(deps): update dependency google-api-python-client to v1.12.1 [(#4674)](GoogleCloudPlatform/python-docs-samples#4674) * chore(deps): update dependency google-auth to v1.21.3 [(#4754)](GoogleCloudPlatform/python-docs-samples#4754) * chore(deps): update dependency google-api-python-client to v1.12.2 [(#4751)](GoogleCloudPlatform/python-docs-samples#4751) * chore: update template * chore: add BUILD_SPECIFIC_GCLOUD_PROJECT env var Co-authored-by: Bill Prin <waprin@google.com> Co-authored-by: Bill Prin <waprin@gmail.com> Co-authored-by: Jon Wayne Parrott <jonwayne@google.com> Co-authored-by: Greg Taylor <snagglepants@gmail.com> Co-authored-by: Jon Wayne Parrott <jon.wayne.parrott@gmail.com> Co-authored-by: DPE bot <dpebot@google.com> Co-authored-by: Takashi Matsuo <tmatsuo@google.com> Co-authored-by: michaelawyu <chenyumic@google.com> Co-authored-by: Campion Fellin <campionfellin@users.noreply.github.com> Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com> Co-authored-by: Jason Dobry <jmdobry@users.noreply.github.com> Co-authored-by: Jeffrey Rennie <rennie@google.com> Co-authored-by: michaelawyu <michael.a.w.yu@hotmail.com> Co-authored-by: Charles Engelke <github@engelke.com> Co-authored-by: Adam Ross <adamross@google.com> Co-authored-by: Charles Engelke <engelke@google.com> Co-authored-by: Gus Class <gguuss@gmail.com> Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com> Co-authored-by: Doug Mahugh <dmahugh@gmail.com> Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Shi Zhang <shizhang@google.com> Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com> Co-authored-by: Leah Cole <coleleah@google.com>

Add google.api.core.gapic_v1.method

a825cdc

theacodes requested review from lukesneeringer and dhermes September 25, 2017 20:00

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2017

theacodes added this to In progress in google.api.core Sep 25, 2017

dhermes reviewed Sep 25, 2017

View reviewed changes

Address review comments

5517874

dhermes reviewed Sep 25, 2017

View reviewed changes

Jon Wayne Parrott added 2 commits September 26, 2017 09:40

Address review comments

21fb29f

Refactor out timeout calculation

4f76f9c

dhermes reviewed Sep 26, 2017

View reviewed changes

Jon Wayne Parrott added 2 commits September 26, 2017 10:28

Moar refactor

cdc7f0f

Fix some docstrings

4b3002a

dhermes reviewed Sep 26, 2017

View reviewed changes

Address review comments

98ff2a4

dhermes approved these changes Sep 26, 2017

View reviewed changes

theacodes merged commit ffff438 into googleapis:master Sep 26, 2017

theacodes deleted the api-core-gapic-method branch September 26, 2017 18:24

theacodes moved this from In progress to Done in google.api.core Sep 26, 2017

theacodes mentioned this pull request Oct 16, 2017

Release core v0.28.0 #4206

Closed

Add google.api.core.gapic_v1.method #4057

Add google.api.core.gapic_v1.method #4057

Conversation

theacodes commented Sep 25, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

theacodes commented Sep 26, 2017 • edited by dhermes

theacodes commented Sep 26, 2017

dhermes commented Sep 26, 2017

theacodes commented Sep 26, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes left a comment

Choose a reason for hiding this comment

theacodes commented Sep 26, 2017 •

edited by dhermes