Changing auth to use implicit environment. #419

dhermes · 2014-12-16T09:50:14Z

FWIW the only real code changes occur in

gcloud/credentials.py
gcloud/datastore/__init__.py
gcloud/datastore/demo/__init__.py
gcloud/storage/__init__.py
gcloud/storage/connection.py -- Some helpers added here should probably be moved elsewhere. Maybe I file a bug?
gcloud/storage/demo/__init__.py
regression/regression_utils.py

Also note that googleapis/oauth2client#93 may be problematic for us, but only in the short term (on the order of days).

Also, I still need to update the encrypted environment variables on Travis.

coveralls · 2014-12-16T09:56:35Z

Coverage remained the same when pulling b4c605a on dhermes:add-better-auth into 31799c3 on GoogleCloudPlatform:master.

gcloud/storage/test_connection.py

        with _Monkey(MUT, crypto=crypto, RSA=rsa, PKCS1_v1_5=pkcs_v1_5,
-                     SHA256=sha256):
+                     SHA256=sha256,
+                     _get_signed_query_params=_get_signed_query_params):


tseaver · 2014-12-16T16:50:27Z

LGTM. Tough that the regression tests don't run on Travis until after the merge, though.

dhermes · 2014-12-16T16:52:16Z

Tough but worth it for the speed-up. I ran them lots and lots though. I was actually planning on letting them fail once before the new environment variables are set up and then re-running after. WDYT?

…_int.

dhermes · 2014-12-16T16:53:49Z

I just pushed 1a1dac0, so we can wait until that passes before merging.

coveralls · 2014-12-16T17:07:42Z

Coverage remained the same when pulling 1a1dac0 on dhermes:add-better-auth into 31799c3 on GoogleCloudPlatform:master.

tseaver · 2014-12-16T17:14:29Z

"Fire when ready, Gridley!"

CONTRIBUTING.rst

-    authenticating with
-  - ``GCLOUD_TESTS_KEY_FILE``: The path to an encrypted key file.
-    See private key
+  - ``GOOGLE_APPLICATION_CREDENTIALS``: The path to an encrypted JSON file;


silvolu · 2014-12-16T17:41:45Z

Looks great! (bar minor comments on wording).
Fixes #247, #335 and #337 right?

dhermes · 2014-12-16T20:02:38Z

@silvolu addressed the incorrect description in 78adc96

This fixes #247 though that is the very issue @craigcitro and I are trying to sort out in googleapis/oauth2client#93. #335 is in some sense already done but I still plan to

Add support and docs for user flow 3-legged auth
Add explicit methods for GAE, GCE and user flow. The branching in the implicit get_credentials() is not necessary in a high-performance, specific environment.
Add docs for how to use non-default creds / create connections with them.

This does not address #337 in total. I wanted things like

dataset.get_dataset()

to work without having to pass in a dataset ID if one could be implied from the environment i.e. via GCE or GAE specific environ vars / metadata or via an environment variable.

coveralls · 2014-12-16T20:03:18Z

Coverage remained the same when pulling 78adc96 on dhermes:add-better-auth into 31799c3 on GoogleCloudPlatform:master.

dhermes · 2014-12-16T20:05:21Z

Feel free to merge if there is nothing else to discuss. I am grading a final right now so am a bit MIA.

tseaver · 2014-12-16T20:48:33Z

Maybe better not merge until we can figure why the trunk has broken regression tests. Of course, they are passing in my sandbox. Looks like @silvolu kicked off a re-run?

silvolu · 2014-12-16T20:50:33Z

@tseaver I did, this one looks extremely transient :)

silvolu · 2014-12-16T21:32:45Z

Build is back to green, merging this one.

Changing auth to use implicit environment.

silvolu · 2014-12-16T22:15:40Z

There's a decryption error on the credentials, I think @dhermes encrypted the file in his fork. I'll update the credentials file.

dhermes · 2014-12-16T22:52:32Z

See my previous comment. The GOOGLE_APPLICATION_CREDENTIALS environment variable has not been set yet.

silvolu · 2014-12-16T22:55:25Z

@dhermes I've set that variable.

silvolu · 2014-12-16T22:58:14Z

Green makes Silvano happy:
https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/44267894

dhermes · 2014-12-16T22:58:35Z

Thanks @silvolu. We are green! w00t

Source-Link: https://togithub.com/googleapis/synthtool/commit/25083af347468dd5f90f69627420f7d452b6c50e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8

Source-Link: googleapis/synthtool@69fabae Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:562802bfac02e012a6ac34eda282f81d06e77326b82a32d7bbb1369ff552b387

…#419)

* chore: Update gapic-generator-python to v1.8.4 PiperOrigin-RevId: 507808936 Source-Link: googleapis/googleapis@64cf849 Source-Link: googleapis/googleapis-gen@53c48ca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

#419) chore: Update test-samples-impl.sh python3.6 --> python3.9 (#418) Source-Link: googleapis/synthtool@1f07110 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:a5d81b61dfd1a432d3c03f51a25d2e71b37be24da509966d50724aea7c57c5c2 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: nicain <nicholascain@google.com> fix test

Source-Link: https://togithub.com/googleapis/synthtool/commit/909573ce9da2819eeb835909c795d29aea5c724e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b

Source-Link: googleapis/synthtool@7197a00 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* feat: Add routing information in Cloud Build GRPC clients PiperOrigin-RevId: 547283196 Source-Link: googleapis/googleapis@64d54ff Source-Link: googleapis/googleapis-gen@1de1822 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWRlMTgyMjExMDliNGEwMjVjMGIyZThjMjUzMjRjYjAxYjZkZjYyNiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: Revert breaking change of main pattern PiperOrigin-RevId: 547506413 Source-Link: googleapis/googleapis@8080bbe Source-Link: googleapis/googleapis-gen@ac98388 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWM5ODM4OGJiODMyZGJlYmMwYmNkNmI3NDgwMDEwNTczYzBiYmRjNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Changing auth to use implicit environment.

b4c605a

tseaver reviewed Dec 16, 2014
View reviewed changes

gcloud/storage/test_connection.py

with _Monkey(MUT, crypto=crypto, RSA=rsa, PKCS1_v1_5=pkcs_v1_5,

SHA256=sha256):

SHA256=sha256,

_get_signed_query_params=_get_signed_query_params):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Removing superfluous patches in test_generate_signed_url_w_expiration…

1a1dac0

…_int.

silvolu reviewed Dec 16, 2014
View reviewed changes

CONTRIBUTING.rst

authenticating with

- ``GCLOUD_TESTS_KEY_FILE``: The path to an encrypted key file.

See private key

- ``GOOGLE_APPLICATION_CREDENTIALS``: The path to an encrypted JSON file;

This comment was marked as spam.

Sign in to view

Changing description of GOOGLE_APPLICATION_CREDENTIALS.

78adc96

silvolu added a commit that referenced this pull request Dec 16, 2014

Merge pull request #419 from dhermes/add-better-auth

ae09738

Changing auth to use implicit environment.

silvolu merged commit ae09738 into googleapis:master Dec 16, 2014

silvolu mentioned this pull request Dec 16, 2014

Support authenticating via GCE metadata server #247

Closed

dhermes deleted the add-better-auth branch December 17, 2014 00:10

dhermes mentioned this pull request Jan 13, 2015

Consider removing hard dependency on PyOpenSSL #537

Closed

dhermes added auth api: core testing api: datastore Issues related to the Datastore API. api: storage Issues related to the Cloud Storage API. labels Dec 31, 2015

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-cloud-securitycenter to v1.17.0 (…

e3a09b0

…#419)

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency backoff to v2.0.1 (#419)

cdb6dad

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(main): release 1.12.1 (#419)

0cd9e2c

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea added a commit that referenced this pull request Oct 21, 2023

docs(samples): fixing file saving for local documents translation (#419)

665c674

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changing auth to use implicit environment. #419

Changing auth to use implicit environment. #419

dhermes commented Dec 16, 2014

coveralls commented Dec 16, 2014

This comment was marked as spam.

This comment was marked as spam.

tseaver commented Dec 16, 2014

dhermes commented Dec 16, 2014

dhermes commented Dec 16, 2014

coveralls commented Dec 16, 2014

tseaver commented Dec 16, 2014

This comment was marked as spam.

silvolu commented Dec 16, 2014

dhermes commented Dec 16, 2014

coveralls commented Dec 16, 2014

dhermes commented Dec 16, 2014

tseaver commented Dec 16, 2014

silvolu commented Dec 16, 2014

silvolu commented Dec 16, 2014

silvolu commented Dec 16, 2014

dhermes commented Dec 16, 2014

silvolu commented Dec 16, 2014

silvolu commented Dec 16, 2014

dhermes commented Dec 16, 2014

Changing auth to use implicit environment. #419

Changing auth to use implicit environment. #419

Conversation

dhermes commented Dec 16, 2014

coveralls commented Dec 16, 2014

This comment was marked as spam.

This comment was marked as spam.

tseaver commented Dec 16, 2014

dhermes commented Dec 16, 2014

dhermes commented Dec 16, 2014

coveralls commented Dec 16, 2014

tseaver commented Dec 16, 2014

This comment was marked as spam.

silvolu commented Dec 16, 2014

dhermes commented Dec 16, 2014

coveralls commented Dec 16, 2014

dhermes commented Dec 16, 2014

tseaver commented Dec 16, 2014

silvolu commented Dec 16, 2014

silvolu commented Dec 16, 2014

silvolu commented Dec 16, 2014

dhermes commented Dec 16, 2014

silvolu commented Dec 16, 2014

silvolu commented Dec 16, 2014

dhermes commented Dec 16, 2014