Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release google-api-core v0.1.0 #4266

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Release google-api-core v0.1.0 #4266

merged 1 commit into from
Oct 26, 2017

Conversation

theacodes
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2017
@theacodes theacodes added this to In progress in google.api.core Oct 26, 2017
@theacodes
Copy link
Contributor Author

Waiting on @dhermes' approval as well.

dhermes
dhermes approved these changes Oct 26, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though do you want code font in more places? Also, do you want to make the issues valid markdown references outside of GitHub or nah?

@lukesneeringer
Copy link
Contributor

Valid on GitHub is fine. When we repo dissect this will end up in the releases area (hopefully in addition to, not instead of, CHANGELOG.md).

@tswast tswast mentioned this pull request Oct 26, 2017
Merged
@theacodes theacodes merged commit 854d904 into googleapis:master Oct 26, 2017
@theacodes theacodes deleted the release-api-core-v0.1.0 branch October 26, 2017 21:52
@theacodes theacodes moved this from In progress to Done in google.api.core Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesneeringer lukesneeringer lukesneeringer approved these changes

@dhermes dhermes dhermes approved these changes

Assignees
No one assigned
Labels
api: core cla: yes This human has signed the Contributor License Agreement. packaging
Projects
No open projects
google.api.core
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@theacodes @lukesneeringer @dhermes @googlebot