Ensure that quickstart examples actually work. #4398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
theacodes
approved these changes
Nov 15, 2017
dhermes
reviewed
Nov 15, 2017
| project_id=os.getenv('GOOGLE_CLOUD_PROJECT'), | ||
| topic='MY_TOPIC_NAME', # Set this to something appropriate. | ||
| ) | ||
| subscription_name = 'projects/{project_id}/subscriptions/{sub}'.format( | ||
| project_id=os.getenv('GOOGLE_CLOUD_PROJECT'), | ||
| sub='MY_SUBSCRIPTION_NAME', # Set this to something appropriate. | ||
| ) | ||
| subscription = subscriber.create_subscription(topic, subscription) | ||
| subscription = subscriber.create_subscription( | ||
| name=subscription_name, topic=topic_name) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@dhermes adding the names makes the call site more robust: back-end / generated code which changes the ordering won't break us, and when they do change the name, we get a nice, informative (StatusCode.INVALID_ARGUMENT, Invalid resource name given (name=projects/PROJECTID/topics/TOPICNAME). Refer to https://cloud.google.com/pubsub/overview#names for more information.)Since that string is a valid topic resource name, I stared at that for a long whilve before figuring out that the error was that |
|
Does anyone have any experience with running code/tests inside documentation via sphinx? E.g http://www.sphinx-doc.org/en/stable/ext/doctest.html |
|
I have lots of it! Hit me up on Hangouts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4394.