Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move datetime helpers from google.cloud._helpers to google.api_core.datetime_helpers #4399

Merged
merged 4 commits into from
Nov 16, 2017
Merged

Move datetime helpers from google.cloud._helpers to google.api_core.datetime_helpers #4399

merged 4 commits into from
Nov 16, 2017

Conversation

theacodes
Copy link
Contributor

Towards #4267

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 15, 2017
dhermes
dhermes approved these changes Nov 15, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theacodes
Copy link
Contributor Author

After chatting with @dhermes, we determined that while we could technically remove all of the if pytz statements from cloud core, it's best to just not modify that library. So instead I'm going to just pragma: NO COVER those lines as a lesser of several evils scenario.

@dhermes
Copy link
Contributor

dhermes commented Nov 16, 2017

Still LGTM, but let's wait for green?

@theacodes
Copy link
Contributor Author

Ya

@theacodes theacodes merged commit 39e4cd4 into googleapis:master Nov 16, 2017
@theacodes theacodes deleted the api-core-datetime-helpers-from-cloud-core branch November 16, 2017 22:37
This was referenced Dec 8, 2017
Merged
Merged
@theacodes theacodes added this to Done in google.api.core Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: core cla: yes This human has signed the Contributor License Agreement.
Projects
No open projects
google.api.core
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@theacodes @dhermes @googlebot