Refactor Pub / Sub callback queue #4511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Also fixing a few typos nearby a mention of `QueueCallbackThread` in `pubsub/CHANGELOG.md`.
dhermes
force-pushed
the
refactor-pubsub-callback-queue
branch
from
b6f66b9
to
0d44af6
Compare
theacodes
reviewed
Dec 6, 2017
| self.nack(**kwargs) | ||
| else: | ||
| raise ValueError( | ||
| 'Unexpected action', action, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
theacodes
approved these changes
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QueueCallbackThread->QueueCallbackWorker.QueueCallbackThreadinpubsub/CHANGELOG.md.Policy.on_callback_request()less open-ended (renaming todispatch_callbackto make it clear that it's essentially acting as a dispatch table for a given action)