Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply scopes to explicitly provided credentials if needed #4594

Merged
merged 2 commits into from
Dec 15, 2017
Merged

Apply scopes to explicitly provided credentials if needed #4594

merged 2 commits into from
Dec 15, 2017

Conversation

theacodes
Copy link
Contributor

Resolves #4479

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 14, 2017
dhermes
dhermes approved these changes Dec 14, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhermes dhermes merged commit 578ff7f into master Dec 15, 2017
@dhermes dhermes deleted the scope-passed-credentials branch December 15, 2017 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: core cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@theacodes @dhermes @googlebot