Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync mtime with updated time #468

Merged
merged 1 commit into from
Jan 8, 2015
Merged

Sync mtime with updated time #468

merged 1 commit into from
Jan 8, 2015

Conversation

grapefruit623
Copy link
Contributor

For issue #311
storage.key.get_contents_to_filename will sync file's mtime and metadata's updated time

dhermes
dhermes reviewed Dec 28, 2014
View reviewed changes
gcloud/storage/key.py
@@ -254,6 +256,11 @@ def download_to_filename(self, filename):
with open(filename, 'wb') as file_obj:
self.download_to_file(file_obj)

mtime = time.mktime(datetime.datetime.strptime(

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling e794ec4 on grapefruit623:issue311 into b343acf on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor

dhermes commented Dec 30, 2014

@grapefruit623 I think it's bad form to have 4 commits for such a small change; it certainly makes the history filled with noise. Would you mind re-writing the history in your branch? I'm happy to help if you're having issues.

As for the change, it seems just fine but I don't feel like I understand reasons not to do this / behavior in other libraries like boto or even behavior via the gsutil CLI tool (now gcloud). Do you know the broader context?

@silvolu silvolu added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 31, 2014
@tseaver
Copy link
Contributor

tseaver commented Dec 31, 2014

@grapefruit623 can you please sign the CLA, as described in CONTRIBUTING.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c25a6e7 on grapefruit623:issue311 into b79d862 on GoogleCloudPlatform:master.

@grapefruit623
Copy link
Contributor Author

Hello, I modified my git commit to one commit so it look like clear.
By the way I have signed the CLA.

@tseaver
Copy link
Contributor

tseaver commented Jan 1, 2015

Thanks, LGTM. @silvolu, can you please confirm the CLA?

@silvolu silvolu added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 5, 2015
@silvolu
Copy link
Contributor

silvolu commented Jan 5, 2015

CLA signed.

@dhermes
Copy link
Contributor

dhermes commented Jan 7, 2015

We are good to merge this?

tseaver added a commit that referenced this pull request Jan 8, 2015
@tseaver
Merge pull request #468 from grapefruit623/issue311
549c175 
Sync mtime with updated time
@tseaver tseaver merged commit 549c175 into googleapis:master Jan 8, 2015
@dhermes dhermes mentioned this pull request Jan 13, 2015
Closed
@grapefruit623 grapefruit623 deleted the issue311 branch January 17, 2015 08:12
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore(python): upgrade gcp-releasetool in .kokoro [autoapprove] (#468)
83de687 
Source-Link: googleapis/synthtool@5f2a608
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot @parthea
feat: add support for new ImportEntries() API, including format of th…
1328b95 
…e dump (#468)

* feat: add support for new ImportEntries() API, including format of the dump
feat: add support for entries associated with Looker and CloudSQL
feat: add support for a ReconcileTags() API method

PiperOrigin-RevId: 516484690

Source-Link: googleapis/googleapis@50eef0f

Source-Link: googleapis/googleapis-gen@09b2058
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDliMjA1ODE5YWE2ZDgyMzkzZWY4NjViNTk2NTcxODE0YzVkMTg0MCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Delete sync-repo-settings to use the default required checks

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Aug 15, 2023
@renovate-bot
chore(deps): update dependency google-cloud-dialogflow-cx to v1.13.5 (#…
3d1daf2 
…468)
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@gcf-owl-bot
feat: add api key support (#468)
b84ea64 
* chore: upgrade gapic-generator-java, gax-java and gapic-generator-python

PiperOrigin-RevId: 423842556

Source-Link: googleapis/googleapis@a616ca0

Source-Link: googleapis/googleapis-gen@29b938c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjliOTM4YzU4YzFlNTFkMDE5ZjJlZTUzOWQ1NWRjMGEzYzg2YTkwNSJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: remove pinned Sphinx version [autoapprove] (#468)
f661e93 
Source-Link: https://togithub.com/googleapis/synthtool/commit/909573ce9da2819eeb835909c795d29aea5c724e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): exclude grpcio==1.49.0rc1 in tests [autoapprove] (#468)
9d3b0e1 
Source-Link: googleapis/synthtool@c4dd595
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72
parthea added a commit that referenced this pull request Sep 22, 2023
@renovate-bot @parthea
chore(deps): update all dependencies (#468)
82f9f03 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-pubsub to v2.13.5 (#468)
0bbb2ed
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(samples): deleting migrated samples (#468)
f7eb90c 
* chore(samples): deleting migrated samples

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 21, 2023
@parthea
fix(deps): allow protobuf < 5.0.0 (#468)
aa4ef4b 
fix(deps): require proto-plus >= 1.22.0
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: fix prerelease_deps nox session [autoapprove] (#468)
14c162a 
Source-Link: https://togithub.com/googleapis/synthtool/commit/26c7505b2f76981ec1707b851e1595c8c06e90fc
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f946c75373c2b0040e8e318c5e85d0cf46bc6e61d0a01f3ef94d8de974ac6790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@grapefruit623 @coveralls @dhermes @tseaver @silvolu