Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accomodate back-end change making 'Sink.filter' optional. #4699

Merged
merged 1 commit into from Jan 5, 2018
Merged

Accomodate back-end change making 'Sink.filter' optional. #4699

merged 1 commit into from Jan 5, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jan 4, 2018

Closes #4696.

@tseaver tseaver added api: logging Issues related to the Cloud Logging API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jan 4, 2018
@tseaver tseaver requested a review from dhermes January 4, 2018 20:44
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 4, 2018
dhermes
dhermes approved these changes Jan 5, 2018
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver tseaver merged commit 90129ef into googleapis:master Jan 5, 2018
@tseaver tseaver deleted the 4696-logging-harden_against_missing_filter branch January 5, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tseaver @dhermes @googlebot