Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose writerIdentity returned in sink resource. #4704

Merged
merged 1 commit into from Jan 5, 2018
Merged

Expose writerIdentity returned in sink resource. #4704

merged 1 commit into from Jan 5, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jan 5, 2018

Closes #4703.

@tseaver tseaver added the api: logging Issues related to the Cloud Logging API. label Jan 5, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 5, 2018
dhermes
dhermes approved these changes Jan 5, 2018
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, why not add it to the constructor?

@tseaver
Copy link
Contributor Author

tseaver commented Jan 5, 2018

why not add it to the constructor?

It is read-only, set by the back-end.

@tseaver tseaver merged commit 444cd41 into googleapis:master Jan 5, 2018
@tseaver tseaver deleted the 4703-logging-expose-writer_identity branch January 5, 2018 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

@chemelnucfin chemelnucfin Awaiting requested review from chemelnucfin

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tseaver @dhermes @googlebot