Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigTable: provide better access to cell values #4908

Merged
merged 10 commits into from Mar 14, 2018
Merged

BigTable: provide better access to cell values #4908

merged 10 commits into from Mar 14, 2018

Conversation

zakons
Copy link
Contributor

@zakons zakons commented Feb 21, 2018

Add methods to provide better access to cell values, with performance and ease of use being additional goals.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 21, 2018
@zakons
Copy link
Contributor Author

zakons commented Feb 21, 2018

Please accept my consent for all commits, passing the CLA check.

@theacodes
Copy link
Contributor

CLAbot has some issues with mixed authorship. Both you and @aneepct have signed the CLA, so don't worry about it.

@theacodes
Copy link
Contributor

@tseaver can you also take a look at this?

tseaver
tseaver suggested changes Feb 21, 2018
View reviewed changes
bigtable/google/cloud/bigtable/row_data.py
except KeyError:
raise KeyError(_MISSING_COLUMN.format(column, column_family_id))

return cells

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

bigtable/google/cloud/bigtable/row_data.py Outdated

return cell.value

def cell_values(self, column_family_id, column, max_count=-1):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

bigtable/google/cloud/bigtable/row_data.py Outdated
if max_count == -1:
max_count = len(cells)

for index, cell in enumerate(cells):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@theacodes
Copy link
Contributor

Does this supersede #4564? If so, can you close it?

@zakons zakons mentioned this pull request Feb 23, 2018
Closed
@tseaver tseaver merged commit 7cf610b into googleapis:master Mar 14, 2018
@zakons
Copy link
Contributor Author

zakons commented Mar 15, 2018

Thanks!

@zakons zakons deleted the feature/cell_values branch March 20, 2018 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduskis sduskis sduskis left review comments

@tseaver tseaver tseaver approved these changes

@theacodes theacodes theacodes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zakons @googlebot @theacodes @sduskis @tseaver