Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry subscription stream on InternalServerError, Unknown, and GatewayTimeout #5021

Merged
merged 1 commit into from Mar 13, 2018
Merged

Retry subscription stream on InternalServerError, Unknown, and GatewayTimeout #5021

merged 1 commit into from Mar 13, 2018

Conversation

theacodes
Copy link
Contributor

Closes #4989

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2018
@chemelnucfin
Copy link
Contributor

@jonparrott How come we can't use the api_core retry here?

@theacodes
Copy link
Contributor Author

We do, it's just that api_core isn't capable of determining the retry strategy for bidirectional streams. Unfortunately, that's pretty api-specific.

@theacodes theacodes merged commit 1367d7b into googleapis:master Mar 13, 2018
@theacodes theacodes deleted the pubsub-retry-on-more-exceptions branch March 13, 2018 16:14
@theacodes theacodes mentioned this pull request Mar 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesneeringer lukesneeringer lukesneeringer approved these changes

@chemelnucfin chemelnucfin chemelnucfin approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@theacodes @chemelnucfin @lukesneeringer @googlebot