Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower the flow control defaults, remove psutil dependency #5248

Merged
merged 1 commit into from Apr 27, 2018

Conversation

theacodes
Copy link
Contributor

Closes #5180

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 26, 2018
@jeanbza
Copy link
Member

jeanbza commented Apr 26, 2018

LGTM!

@@ -31,7 +31,6 @@
dependencies = [
'google-api-core[grpc]<2.0.0dev,>=0.1.3',
'grpc-google-iam-v1<0.12dev,>=0.11.1',
'psutil<6.0dev,>=5.2.2',

This comment was marked as spam.

@theacodes theacodes merged commit df55846 into googleapis:master Apr 27, 2018
@theacodes theacodes deleted the pubsub-flow-control-defaults branch April 27, 2018 16:02
@gylu
Copy link

gylu commented Jun 14, 2018

I'm not sure what the accepted norm is, but just wondering, can changes like these be documented as "Breaking"? Updating the PubSub library broke our system because these defaults changed and I was only looking for "Breaking Changes" instead of also "Implementation Changes"

@csoare7
Copy link

csoare7 commented Oct 11, 2018

@gylu was wondering how did you manage to fix your PubSub library? This update also breaks our Cloud Storage library, as we're getting ModuleNotFoundError: No module named 'google'

@gylu
Copy link

gylu commented Oct 11, 2018

@csoare7 I rewrote the code. Hehe. I guess the lesson learned is to read all the release notes, and maybe update less often.

@tseaver
Copy link
Contributor

tseaver commented Oct 11, 2018

@csoare7 You likely need to reinstall in a fresh environment, using current setuptools / pip. E.g.:

$ python3.6 -m venv /path/to/new_venv
$ /path/to/new_venv/bin/pip install -U setuptools pip
...
Successfully installed pip-18.1 setuptools-40.4.3
$ /path/to/new_venv/bin/pip install google-cloud-pubsub google-cloud-storage
...
Successfully installed cachetools-2.1.0 certifi-2018.8.24 chardet-3.0.4 google-api-core-1.4.1 google-auth-1.5.1 google-cloud-core-0.28.1 google-cloud-pubsub-0.38.0 google-cloud-storage-1.13.0 google-resumable-media-0.3.1 googleapis-common-protos-1.5.3 grpc-google-iam-v1-0.11.4 grpcio-1.15.0 idna-2.7 protobuf-3.6.1 pyasn1-0.4.4 pyasn1-modules-0.2.2 pytz-2018.5 requests-2.19.1 rsa-4.0 six-1.11.0 urllib3-1.23
$ /path/to/new_venv/bin/python -c "import google; print(google.__path__)"
_NamespacePath(['/path/to/new_venv/lib/python3.6/site-packages/google'])

@tseaver
Copy link
Contributor

tseaver commented Oct 11, 2018

@gylu Can you go into more detail about how your application broke? The change in this PR should have been innocuous: were you depending on having psutil installed via a transitive dependency? Or was it the smaller defaults that broke you?

@csoare7
Copy link

csoare7 commented Oct 11, 2018

@tseaver thanks for the comment, that's what I did locally and can confirm it works. However this breaks the test environment - we're running on Docker containers so every test build is a fresh environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants