Promote subscribe_experimental() to subscribe(), remove old subscriber implementation. #5274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r implementation. This removes the following public interfaces: * pubsub_v1.subscriber.policy.base * pubsub_v1.subscriber.policy.thread * pubsub_v1.subscriber.futures.Future * pubsub_v1.subscriber.client.Client.subscribe_experimental
googlebot
added
the
cla: yes
theacodes
changed the title
crwilcox
suggested changes
Apr 30, 2018
docs/pubsub/subscriber/index.rst
Outdated
| subscription string. | ||
| step is to pull data from it. The subscriber client uses the | ||
| :meth:`~.pubsub_v1.subscriber.client.Client.subscribe` method to start a | ||
| backgroud thread to receive messages from Pub/Sub and calls a callback with |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
docs/pubsub/subscriber/index.rst
Outdated
| @@ -115,6 +123,15 @@ thread will be set on the future. | |||
| subscription.close() | |||
| raise | |||
|
|
|||
| Finally, you can use | |||
| :meth:`~.pubsub_v1.subscriber.futures.StreamingPullFuture.cancel` to stop | |||
| recieving messages. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
crwilcox
approved these changes
Apr 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the following public interfaces: