Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test runs for Python 3.7 and remove 3.4 #5295

Merged
merged 3 commits into from May 4, 2018

Conversation

crwilcox
Copy link
Contributor

@crwilcox crwilcox commented May 3, 2018

There are very few people using 3.4 and 3.7 is coming up. A few of the packages cannot use 3.7 yet

PubSub: #5292
Monitoring: #5293
BigQuery: #5294

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 3, 2018
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@tseaver
Copy link
Contributor

tseaver commented May 3, 2018

Are you sure about the 3.4 bit? It is still the default python3 for LTS Linux versions, AFAIK.

@crwilcox
Copy link
Contributor Author

crwilcox commented May 3, 2018

@tseaver: @jonparrott looked up the stats and said ~4%. We can leave it if you have strong feelings about it. It seemed a convenient time to not elongate the test runs is all.

@theacodes
Copy link
Contributor

theacodes commented May 3, 2018 via email

@theacodes
Copy link
Contributor

Okay, looking over the last 6 months of download stats from BigQuery:


  SELECT
    details.python, COUNT(*) as total_downloads,
  FROM
    TABLE_DATE_RANGE(
      [the-psf:pypi.downloads],
      DATE_ADD(CURRENT_TIMESTAMP(), -6, "month"),
      CURRENT_TIMESTAMP()
    )
  WHERE
    file.project LIKE 'google-cloud%'
  GROUP BY details.python
  ORDER BY details.python DESC

Our packages have been installed a total of 54,568,855 times with 785,977 of those downloads originating from a Python 3.4 version. That means that Python 3.4 accounts for just 1.44% of our install base. By comparison, 3.4 accounts for 3.58% of the overall installs for all packages over the last 6 months.

Summoning @tswast to make sure I didn't do something stupid here.

@tswast
Copy link
Contributor

tswast commented May 3, 2018

Query looks right, though I'd filter out the "bandersnatch" installs with details.installer.name = 'pip' if I were you. In my experiments those are a significant percentage of downloads and don't actually count as installs since they mirror all of PyPI.

P.S. I could give you some help updating to standard SQL syntax if you'd like.

@theacodes
Copy link
Contributor

Thanks @tswast. Limiting to just pip installs made the Py 3.4 percentage even lower at 1.43%. ;)

@crwilcox crwilcox merged commit 10cd5e5 into googleapis:master May 4, 2018
@tswast
Copy link
Contributor

tswast commented May 29, 2018

As pointed out by @tseaver in #5401, this also requires an update to all setup.py files.

atulep pushed a commit that referenced this pull request Apr 3, 2023
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
atulep pushed a commit that referenced this pull request Apr 18, 2023
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this pull request Jun 4, 2023
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this pull request Jun 4, 2023
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this pull request Jul 6, 2023
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this pull request Sep 22, 2023
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this pull request Sep 22, 2023
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this pull request Sep 22, 2023
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this pull request Sep 22, 2023
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this pull request Sep 22, 2023
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this pull request Sep 22, 2023
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this pull request Oct 21, 2023
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this pull request Oct 21, 2023
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this pull request Oct 21, 2023
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this pull request Oct 22, 2023
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this pull request Oct 22, 2023
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
parthea pushed a commit that referenced this pull request Oct 31, 2023
* remove 3.4 from unit test runs

* add 3.7 to most packages. PubSub, Monitoring, BigQuery not enabled

* Fix #5292 by draining queue in a way compatible with SimpleQueue and Queue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants