Trace: Pass credentials into TraceServiceClient #5596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@liyanhui1228 @theacodes ptal |
tseaver
suggested changes
Aug 8, 2018
trace/google/cloud/trace/_gapic.py
Outdated
| @@ -14,8 +14,9 @@ | |||
|
|
|||
| """Wrapper for interacting with the Stackdriver Trace API.""" | |||
|
|
|||
| from google.api_core.gapic_v1 import method | |||
| from google.api_core.gapic_v1 import client_info, method | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
kornholi
force-pushed
the
trace-credentials-fix
branch
from
e99430e
to
43479cd
Compare
tseaver
approved these changes
Aug 8, 2018
|
@kornholi Thank you for the patch! |
AVaksman
pushed a commit
to AVaksman/google-cloud-python
that referenced
this pull request
Aug 16, 2018
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_trace_apicurrently ignores the credentials configured in theClient