Logging: harden sink creation against transient errors. #6180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tseaver
added
testing
api: logging
googlebot
added
the
cla: yes
Also, remove deprecated use of 'failIf'. Closes #5931.
tseaver
force-pushed
the
5931-logging-harden-test_update_sink
branch
from
59801fb
to
72f8fb9
Compare
tseaver
added
the
kokoro:force-run
tseaver
removed
the
kokoro:force-run
|
Yet another testing-only change, working to keep the logging systests green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, remove deprecated use of 'failIf'.
Closes #5931.