Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-generate library using dlp/synth.py #6221

Merged
merged 3 commits into from Oct 17, 2018
Merged

Re-generate library using dlp/synth.py #6221

merged 3 commits into from Oct 17, 2018

Conversation

dpebot
Copy link
Contributor

@dpebot dpebot commented Oct 16, 2018

This PR was created by autosynth.

@dpebot dpebot requested a review from crwilcox as a code owner October 16, 2018 16:34
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 16, 2018
@crwilcox
Copy link
Contributor

Generated docstr have failure.

sphinx.errors.SphinxWarning: /var/code/gcp/dlp/google/cloud/dlp_v2/__init__.py:docstring of google.cloud.dlp_v2.DlpServiceClient.list_stored_info_types:46:Bullet list ends without a blank line; unexpected unindent.

@tseaver tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work. api: dlp Issues related to the Sensitive Data Protection API. labels Oct 17, 2018
@tseaver
Copy link
Contributor

tseaver commented Oct 17, 2018

DLP tests did not actually run, due to #6231. Please hold off merging until that issue is fixed, and then force a rebuild for the Kokoro DLP job(how?)

tseaver
tseaver suggested changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

synth needs to fix up yet-another-docstring: the docs build fails with:

sphinx.errors.SphinxWarning: /var/code/gcp/dlp/google/cloud/dlp_v2/init.py:docstring of google.cloud.dlp_v2.DlpServiceClient.list_stored_info_types:46:Bullet list ends without a blank line; unexpected unindent.

@chrisrossi chrisrossi self-assigned this Oct 17, 2018
@chrisrossi chrisrossi removed their assignment Oct 17, 2018
tseaver
tseaver reviewed Oct 17, 2018
View reviewed changes
dlp/google/cloud/dlp_v2/proto/dlp_pb2_grpc.py Outdated
context.set_code(grpc.StatusCode.UNIMPLEMENTED)
context.set_details('Method not implemented!')
raise NotImplementedError('Method not implemented!')

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2018
@tseaver tseaver removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work. labels Oct 17, 2018
@tseaver tseaver merged commit ba4e7d5 into master Oct 17, 2018
@tseaver tseaver deleted the autosynth-dlp branch October 17, 2018 19:07
parthea pushed a commit that referenced this pull request Sep 22, 2023
@dpebot @tseaver
Re-generate library using dlp/synth.py (#6221)
5b430be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: dlp Issues related to the Sensitive Data Protection API. cla: yes This human has signed the Contributor License Agreement. codegen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dpebot @crwilcox @tseaver @chrisrossi @googlebot @kokoro-team