Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: remove use of deprecated 'channel' argument. #6271

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Firestore: remove use of deprecated 'channel' argument. #6271

merged 1 commit into from
Oct 24, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 18, 2018

Use mocks and a custom iterator to bypass the underlying GAPIC client altogether.

@tseaver
Remove use of deprecated 'channel' argument.
5934f9a 
Instead, just use mocks and a custom iterator to bypass the underlying
GAPIC client altogether.
@tseaver tseaver added testing api: firestore Issues related to the Firestore API. labels Oct 18, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 18, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Oct 24, 2018

Merging without review: uncontroversial, testing-only change.

@tseaver tseaver merged commit 372bad1 into googleapis:master Oct 24, 2018
@tseaver tseaver deleted the firestore-avoid_deprecated_usage_in_tests branch October 24, 2018 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tseaver @googlebot