Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prep 'api_core-1.5.1' release. #6329

Closed
wants to merge 3 commits into from
Closed

Prep 'api_core-1.5.1' release. #6329

wants to merge 3 commits into from

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 29, 2018 •
edited

Release to be made from api_core-1.5.x-maint branch, if that strategy is chosen (see #6328 for the alternate strategy of repairing the master branch).

Closes #6326.

tswast and others added 2 commits October 29, 2018 15:59
@tswast @tseaver
Don't URL-encode slashes in gRPC request headers. (#6310)
ad1e32f 
Per internal document go/api-url-encoding (approved on 2017-04-20), "the
client library will %-encode everything except "/" and unreserved
characters, and the server will %-decode everything except "%2F"
and %2f"

This is currently affecting a private API which passes a resource name
(containing slashes) as a query parameter over gRPC.

Toward #6326.

(cherry picked from commit e368317)
@tseaver
Prep 'api_core-1.5.1' release.
4d103ea 
Closes #6362.
@tseaver tseaver requested a review from crwilcox October 29, 2018 20:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2018
@tseaver tseaver mentioned this pull request Oct 29, 2018
Merged
@tseaver
Copy link
Contributor Author

tseaver commented Oct 29, 2018

After discussion with @crwilcox, closing in favor of #6328.

@tseaver tseaver closed this Oct 29, 2018
@tseaver tseaver deleted the 6326-prep-api_core-1.5.1-release branch October 29, 2018 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

@theacodes theacodes Awaiting requested review from theacodes

Assignees
No one assigned
Labels
api: core cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tseaver @googlebot @tswast