Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: enable use of 'WriteBatch' as a context manager. #6912

Merged
merged 4 commits into from Dec 17, 2018
Merged

Firestore: enable use of 'WriteBatch' as a context manager. #6912

merged 4 commits into from Dec 17, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 12, 2018

Closes #6548.

@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Dec 12, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 12, 2018
@tseaver tseaver requested a review from mcdonc December 12, 2018 22:13
@tseaver
Copy link
Contributor Author

tseaver commented Dec 13, 2018

@crwilcox Failed systests are all due to quota issues in the watch tests.

mcdonc
mcdonc approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@mcdonc mcdonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver tseaver merged commit 54e87e1 into googleapis:master Dec 17, 2018
@tseaver tseaver deleted the 6548-firestore-batch_context_mgr branch December 17, 2018 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonc mcdonc mcdonc approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tseaver @mcdonc @googlebot