Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: implement listen conformance #6935

Merged
merged 2 commits into from
Dec 18, 2018
Merged

Firestore: implement listen conformance #6935

merged 2 commits into from
Dec 18, 2018

Conversation

mcdonc
Copy link
Contributor

@mcdonc mcdonc commented Dec 17, 2018

Fixes two bugs in the watch code:

  • always-truthiness of protobufs foiled a delete/remove document case.
  • change map would receive keys that were document snapshots instead of document names sometimes,
    foiling the reset code.

Closes #6533

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 17, 2018
@tseaver tseaver changed the title implement listen conformance Firestore: implement listen conformance Dec 17, 2018
@tseaver tseaver added testing api: firestore Issues related to the Firestore API. labels Dec 17, 2018
tseaver
tseaver suggested changes Dec 17, 2018
View reviewed changes
firestore/google/cloud/firestore_v1beta1/watch.py Outdated Show resolved Hide resolved
firestore/tests/unit/test_watch.py Show resolved Hide resolved
@mcdonc mcdonc mentioned this pull request Dec 17, 2018
Closed
@tseaver
Copy link
Contributor

tseaver commented Dec 18, 2018

Firestore system test failures due to quota issues.

@tseaver tseaver merged commit 6b7d6cf into googleapis:master Dec 18, 2018
@tseaver tseaver mentioned this pull request Dec 18, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcdonc @tseaver @googlebot