Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigtable: improve 'Policy' interchange w/ JSON, gRPC payloads. #7378

Merged
merged 3 commits into from
Feb 20, 2019
Merged

Bigtable: improve 'Policy' interchange w/ JSON, gRPC payloads. #7378

merged 3 commits into from
Feb 20, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Feb 18, 2019

Closes #7369.

@tseaver
Add 'Policy.from_pb' factory and 'Policy.to_pb' method.
659a695 
Use them for interchange with the 'google.iam.v1.policy_pb2.Policy'
messages.
@tseaver
Override 'Policy.{from_api_repr,to_api_repr}'.
cfc7fae 
Convert 'etag' attr to / from bytes to maintain JSON compatibility.

Closes #7369.
@tseaver tseaver added the api: bigtable Issues related to the Bigtable API. label Feb 18, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 18, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Feb 19, 2019

@crwilcox Unrelated Kokoro failures (these jobs shouldn't even be run, karthago delenda est):

  • pubsub, "Failed to clone GitHub repository"
  • language, "Failed to clone GitHub repository"
  • securitycenter, "Failed to clone GitHub repository"
  • vision: non-public Kokoro URL.

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2019
@tseaver tseaver merged commit 563d083 into googleapis:master Feb 20, 2019
@tseaver tseaver deleted the 7369-bigtable-policy_etag_json branch February 20, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tseaver @googlebot @yoshi-kokoro