Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DLP: Add support for filtering job triggers, add CryptoDeterministicConfig, update docs/conf.py. (via synth). #7390

Merged
merged 3 commits into from
Apr 15, 2019
Merged

DLP: Add support for filtering job triggers, add CryptoDeterministicConfig, update docs/conf.py. (via synth). #7390

merged 3 commits into from
Apr 15, 2019

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/dlp/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:5fd9aee1d82a00cebf425c8fa431f5457539562f5867ad9c54370f0ec9a7ccaa
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/privacy/dlp/artman_dlp_v2.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/dlp-v2.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/privacy/dlp/v2/dlp.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/dlp-v2/google/cloud/dlp_v2/proto/dlp.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/privacy/dlp/v2/storage.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/dlp-v2/google/cloud/dlp_v2/proto/storage.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/dlp-v2/google/cloud/dlp_v2/proto.
synthtool > Replaced 'google\\.cloud\\.privacy\\.dlp_v2' in google/cloud/dlp_v2/proto/storage_pb2.py.
synthtool > Replaced 'google\\.cloud\\.privacy\\.dlp_v2' in google/cloud/dlp_v2/proto/dlp_pb2_grpc.py.
synthtool > Replaced 'google\\.cloud\\.privacy\\.dlp_v2' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '# Generated by the protocol buffer compiler.  DO NOT EDIT!' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced 'number regex.*\n(\\s+)latex:.*\n' in google/cloud/dlp_v2/proto/storage_pb2.py.
synthtool > Replaced '(hotword_regex:)\n(\\s+Regular expression.*)\n' in google/cloud/dlp_v2/proto/storage_pb2.py.
synthtool > Replaced '(likelihood_adjustment:)\n' in google/cloud/dlp_v2/proto/storage_pb2.py.
synthtool > No replacements made in google/cloud/dlp_v2/proto/dlp_pb2.py for pattern (max_findings_per_item:)
(\s+Max number.*)
(\s+scanned. When.*)
(\s+maximum returned is 1000.*)
(\s+When set within.*)
, maybe replacement is not longer needed?
synthtool > Replaced '(max_findings_per_request:)\n(\\s+Max number of.*)\n(\\s+When set .*)\n' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(max_findings_per_info_type:)\n' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(snapshot_inspect_template:)\n(\\s+If run with an .*)\n' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(processed_bytes:)\n' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(total_estimated_bytes:)\n' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(info_type_stats:)\n' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(Statistics of how many instances of each info type were found)\n' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(requested_options:)\n' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(sensitive_value_frequency_lower_bound:)\n(\\s+Lower bound.*)\n' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(sensitive_value_frequency_upper_bound:)\n(\\s+Upper bound.*)\n' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(bucket_size:)\n(\\s+Total number of equivalence.*)\n' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(bucket_values:)\n(\\s+Sample of equivalence.*)\n' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(offset_minutes:)\n(\\s+Set only.*)\n' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(result:)\n(\\s+A summary of the outcome of this inspect job.)' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(storage_config:)\n(\\s+The data to scan.\n)' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(inspect_config:)\n(\\s+How and what to scan for.\n)' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(inspect_template_name:)\n(\\s+If provided, will be.*)\n(\\s+InspectConfig.*)\n(\\s+values persisted.*)\n(\\s+actions:)\n(\\s+Actions to.*)\n' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '    (\\s+Set of values defining the equivalence class.*)\n    (\\s+quasi-identifier.*)\n    (\\s+message. The order.*)\n' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '    (\\s+Size of the equivalence class, for example number of rows with)\n    (\\s+the above set of values.)\n' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(equivalence_class_size_lower_bound:)\n(\\s+Lower bound.*)\n' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(equivalence_class_size_upper_bound:)\n(\\s+Upper bound.*)\n' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(bucket_value_count:)\n(\\s+Total number of distinct equivalence.*)\n' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(value_frequency_lower_bound:)\n\\s+(Lower bound.*)\n\\s+(bucket.\n)(\\s+value_frequency_upper.*)\n\\s+(Upper.*)\n\\s+(bucket.\n)(\\s+bucket_size:)\n\\s+(Total.*\n)(\\s+bucket_values:)\n\\s+(Sample of value.*)\n\\s+(of values.*\n)(\\s+bucket_value_count:)\n\\s+(Total number.*\n)' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(DESCRIPTOR .*_TAGGEDFIELD,\n\\s+__module__.*\n\\s+,\n\\s+__doc__.*\n)(\\s+field:)\n(\\s+Identifies .*)\n(\\s+tag:)\n(\\s+Semantic.*)\n(\\s+determine.*)\n(\\s+reidentifiability.*)\n(\\s+info_type:)\n(\\s+A column.*)\n(\\s+public dataset.*)\n(\\s+available.*)\n(\\s+ages.*)\n(\\s+supported Info.*)\n(\\s+supported.*)\n(\\s+custom_tag:)\n(\\s+A col.*)\n(\\s+user must.*)\n(\\s+statist.*)\n(\\s+\\(below.*)\n(\\s+inferred:)\n(\\s+If no semantic.*)\n' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '(////////.*)\n\\s+(///////////////\n)' in google/cloud/dlp_v2/proto/dlp_pb2.py.
synthtool > Replaced '^\\s+resource was created.' in google/cloud/dlp_v2/gapic/dlp_service_client.py.
synthtool > Replaced '(\\s+)WHITESPACE \\(int\\).*\n' in google/cloud/dlp_v2/gapic/enums.py.
synthtool > Replaced '.*:raw-latex:.*\n' in google/cloud/dlp_v2/gapic/enums.py.
.coveragerc
.flake8
MANIFEST.in
noxfile.py.j2
setup.cfg
Running session blacken
Creating virtualenv using python3.6 in /tmpfs/src/git/autosynth/working_repo/dlp/.nox/blacken
pip install --upgrade black
black google tests docs
reformatted /tmpfs/src/git/autosynth/working_repo/dlp/google/cloud/dlp.py
reformatted /tmpfs/src/git/autosynth/working_repo/dlp/google/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/dlp/google/cloud/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/dlp/google/cloud/dlp_v2/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/dlp/docs/conf.py
reformatted /tmpfs/src/git/autosynth/working_repo/dlp/google/cloud/dlp_v2/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/dlp/google/cloud/dlp_v2/gapic/dlp_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/dlp/google/cloud/dlp_v2/gapic/transports/dlp_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/dlp/google/cloud/dlp_v2/proto/dlp_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/dlp/google/cloud/dlp_v2/proto/storage_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/dlp/google/cloud/dlp_v2/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/dlp/google/cloud/dlp_v2/gapic/dlp_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/dlp/tests/unit/gapic/v2/test_dlp_service_client_v2.py
reformatted /tmpfs/src/git/autosynth/working_repo/dlp/google/cloud/dlp_v2/proto/storage_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/dlp/google/cloud/dlp_v2/proto/dlp_pb2.py
All done! ✨ 🍰 ✨
15 files reformatted, 4 files left unchanged.
Session blacken was successful.
synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: dlp Issues related to the Sensitive Data Protection API. label Feb 20, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 20, 2019
@tseaver tseaver changed the title [CHANGE ME] Re-generated dlp to pick up changes in the API or client library generator. DLP: add support for filtering job triggers (via synth). Feb 20, 2019
tseaver
tseaver reviewed Feb 20, 2019
View reviewed changes
dlp/google/cloud/dlp_v2/proto/dlp.proto
post: "/v2/{name=projects/*/jobTriggers/*}:activate"
body: "*"
};
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crwilcox Why didn't this additional RPC cause an activate_job_trigger method to be added in dlp_service_client.py?

Copy link
Contributor

@busunkim96 busunkim96 Apr 15, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is disabled in the GAPIC config, so this is expected behavior. See https://github.com/googleapis/googleapis/blob/fd67be4b51a8c809b97100ccf1c3cffd15b85d7b/google/privacy/dlp/v2/dlp_gapic.yaml#L372-L382 and internal PR 240813399.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 27, 2019
@tseaver tseaver added needs work This is a pull request that needs a little love. and removed 🚨 This issue needs some love. labels Mar 4, 2019
@busunkim96 busunkim96 removed the needs work This is a pull request that needs a little love. label Apr 15, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 15, 2019
@busunkim96 busunkim96 changed the title DLP: add support for filtering job triggers (via synth). DLP: Add support for filtering job triggers, add CryptoDeterministicConfig, update docs/conf.py. (via synth). Apr 15, 2019
@busunkim96 busunkim96 removed the 🚨 This issue needs some love. label Apr 15, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 15, 2019
@busunkim96 busunkim96 merged commit a96fa64 into master Apr 15, 2019
parthea pushed a commit that referenced this pull request Sep 22, 2023
@yoshi-automation @busunkim96
DLP: Add support for filtering job triggers, add CryptoDeterministicC…
0eaab02 
…onfig, update docs/conf.py. (via synth). (#7390)

* Regenerate client.

* Fix docstrings with no summary line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver left review comments

@busunkim96 busunkim96 busunkim96 left review comments

@crwilcox crwilcox crwilcox approved these changes

Assignees
No one assigned
Labels
api: dlp Issues related to the Sensitive Data Protection API. cla: yes This human has signed the Contributor License Agreement. codegen 🚨 This issue needs some love.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yoshi-automation @tseaver @crwilcox @busunkim96 @googlebot