-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Way to change the mutation timeout in bigtable. #7424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the patch! I think we can simplify it a bit.
I do all the changes. @tseaver |
bd123f0
to
374e9ac
Compare
resolved it |
@juan-rael Thanks for working through my review. In future PRs, please don't rebase / squash when replying to review comments: keeping the commits separate makes it easier to verify that the requested change was made. We end up squash-merging the whole thing at the end, anyway. |
In some cases, we need to set a greater timeout to wait for a request, right now it isn't a way to change this value.
setting the timeout in the
mutation batcher
we can set this time or set it in blank to take the default value.