-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bigtable: cleanup unused variable and add deprecation warnings for to be removed features #7532
Bigtable: cleanup unused variable and add deprecation warnings for to be removed features #7532
Conversation
* add deprecation warnings for backwards compatible features that will go away
_INSTANCE_CREATE_WARNING.format( | ||
"location_id", "serve_nodes", "default_storage_type" | ||
), | ||
PendingDeprecationWarning, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can make this just a regular DeprecationWarning
. Thanks for adding stacklevel=2
!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks
@AVaksman We need to update the unit tests to catch / assert the new warnings being raised, e.g.: def test_foo(self):
import warnings
with warnings.catch_warnings(record=True) as warned:
foo()
self.assertEqual(len(warned), 1)
self.assertTrue(issubclass(warned[0].category, DeprecationWarning) |
Done, thanks |
Unrelated test failures:
|
Fixes #7531