Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text-to-Speech: Remove empty 'api.rst' from docs #7645

Closed
wants to merge 1 commit into from
Closed

Text-to-Speech: Remove empty 'api.rst' from docs #7645

wants to merge 1 commit into from

Conversation

busunkim96
Copy link
Contributor

Fixes #7629.

@busunkim96 busunkim96 added api: texttospeech Issues related to the Text-to-Speech API. type: docs Improvement to the documentation for an API. labels Apr 2, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 2, 2019
@busunkim96 busunkim96 requested a review from tswast April 2, 2019 21:34
tswast
tswast approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I assume there hasn't been any content here for a while, so no redirects are needed?

@busunkim96
Copy link
Contributor Author

Hmm, It looks like this fixed docs links back in #5483. The contents reference the trace client, which doesn't seem to be related to TTS. I will do a bit more investigating.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 9, 2019
tseaver
tseaver suggested changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the api.rst file is clearly broken, ISTM it would be better to fix the links than to remove it.

@tseaver tseaver changed the title Remove empty 'api.rst' from docs Text-to-Speech: Remove empty 'api.rst' from docs Jun 19, 2019
@tseaver tseaver mentioned this pull request Jun 19, 2019
Merged
@tseaver
Copy link
Contributor

tseaver commented Jun 19, 2019

Superseded by #8435.

@tseaver tseaver closed this Jun 19, 2019
tseaver added a commit that referenced this pull request Jun 19, 2019
@tseaver
Repair top-level API reference page. (#8435)
84b83a6 
Supersedes #7645.

Fixes #7629.
parthea pushed a commit that referenced this pull request Sep 22, 2023
@tseaver
Repair top-level API reference page. (#8435)
261ba02 
Supersedes #7645.

Fixes #7629.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver requested changes

@tswast tswast tswast approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: texttospeech Issues related to the Text-to-Speech API. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty API page in "Python Client for Cloud Text-to-Speech API"
5 participants
@busunkim96 @tseaver @tswast @googlebot @yoshi-automation