Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigtable, Firestore: fix client_info type in GAPIC-based client docstrings. #7898

Merged
merged 1 commit into from
May 8, 2019
Merged

Bigtable, Firestore: fix client_info type in GAPIC-based client docstrings. #7898

merged 1 commit into from
May 8, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 8, 2019

@tswast Addressing your comments which I missed seeing before merging #7876 / #7877.

@tseaver tseaver added api: bigtable Issues related to the Bigtable API. api: firestore Issues related to the Firestore API. type: docs Improvement to the documentation for an API. labels May 8, 2019
@tseaver tseaver requested a review from tswast May 8, 2019 16:16
@tseaver tseaver requested a review from crwilcox as a code owner May 8, 2019 16:16
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2019
tswast
tswast approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up with this.

@tseaver tseaver merged commit de0103c into googleapis:master May 8, 2019
@tseaver tseaver deleted the 7876-bigtable-7877-firestore-client_info-docstring-fix branch May 8, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tseaver @tswast @googlebot