Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trace: add client_info support to clients. #7899

Merged
merged 4 commits into from
May 8, 2019
Merged

Trace: add client_info support to clients. #7899

merged 4 commits into from
May 8, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 8, 2019

Toward #7825.

@tseaver tseaver added the api: cloudtrace Issues related to the Cloud Trace API. label May 8, 2019
@tseaver tseaver requested a review from tswast May 8, 2019 17:48
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2019
@tswast tswast mentioned this pull request May 8, 2019
Closed
14 tasks
@tswast
Copy link
Contributor

tswast commented May 8, 2019

Linter failing (needs to be blackened).

Coverage failing

coverage report --show-missing --fail-under=100
Name                                Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------------------------
google/cloud/trace/__init__.py         12      0      0      0   100%
google/cloud/trace/_gapic.py           55      0     16      0   100%
google/cloud/trace/client.py           19      0      2      0   100%
google/cloud/trace/v1/__init__.py       3      0      0      0   100%
google/cloud/trace/v1/_gapic.py        38      2      0      0    95%   164-165
google/cloud/trace/v1/client.py        32      0     12      0   100%
google/cloud/trace_v1/__init__.py       8      0      0      0   100%
google/cloud/trace_v1/types.py         19      0      8      0   100%
google/cloud/trace_v2/__init__.py       8      0      0      0   100%
google/cloud/trace_v2/types.py         23      0      8      0   100%
-------------------------------------------------------------------------------
TOTAL                                 217      2     46      0    99%

https://source.cloud.google.com/results/invocations/97c40a9f-2a86-4639-b98f-11a5b146a23f/targets/cloud-devrel%2Fclient-libraries%2Fgoogle-cloud-python%2Fpresubmit%2Ftrace/log

tswast
tswast approved these changes May 8, 2019
View reviewed changes
trace/google/cloud/trace/client.py Outdated Show resolved Hide resolved
trace/tests/unit/v1/test__gapic_v1.py Show resolved Hide resolved
@tseaver tseaver merged commit d613b57 into googleapis:master May 8, 2019
@tseaver tseaver deleted the 7825-trace-add-client_info-support branch May 8, 2019 20:33
parthea pushed a commit that referenced this pull request Oct 22, 2023
@tseaver
Add client_info support to clients. (#7899)
8dbd9be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: cloudtrace Issues related to the Cloud Trace API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tseaver @tswast @googlebot