Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: use correct environment variable to guard the 'system' part. #7912

Merged
merged 2 commits into from
May 17, 2019
Merged

Firestore: use correct environment variable to guard the 'system' part. #7912

merged 2 commits into from
May 17, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 9, 2019

Firestore's system tests use a different environment variable (because firestore vs. datastore hysterical raisins).

@tseaver tseaver added testing api: firestore Issues related to the Firestore API. labels May 9, 2019
@tseaver tseaver requested a review from crwilcox May 9, 2019 17:12
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 9, 2019
@tseaver tseaver added the codegen label May 9, 2019
busunkim96
busunkim96 reviewed May 9, 2019
View reviewed changes
firestore/noxfile.py Outdated Show resolved Hide resolved
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 16, 2019
@tseaver
Copy link
Contributor Author

tseaver commented May 16, 2019

@busunkim96 I fixed the docs session issue by regenerating with an up-to-date version of sythtool. PTAL.

@tseaver tseaver merged commit c97bef4 into googleapis:master May 17, 2019
@tseaver tseaver deleted the firestore-nox-correct-systest-envvar branch May 17, 2019 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 left review comments

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. codegen 🚨 This issue needs some love. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tseaver @busunkim96 @googlebot @yoshi-automation