Respect timeout on client.read_rows. Don't resume on DEADLINE_EXCEEDED errors.
#8025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
…EDED` errors. DEADLINE_EXCEEDED should not be resumed. Currently, you can set a timeout on reads, but the reader will reconnect after the timeout value finishes. Always resuming the stream masked internal issue 132959978 from clients, where the default deadline is much too low for read streams. Wait for the deadline configuration fix for read rows to go in before merging.
tswast
force-pushed
the
b132959978-bqstorage-deadline-exceeded
branch
from
114b096
to
a8e38b1
Compare
shollyman
approved these changes
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEADLINE_EXCEEDED should not be resumed. Currently, you can set a
timeout on reads, but the reader will reconnect after the timeout value
finishes.
Always resuming the stream masked internal issue 132959978 from clients,
where the default deadline is much too low for read streams.
Wait for the deadline configuration fix for read rows to go in before
merging.