PubSub: Add system tests for PubSub clients #8277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
plamut
commented
Jun 11, 2019
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
The PubSub backend does not give any guarantees about when a message will be re-delivered after seeking back to a snapshot, it will only be delivered "eventually". That causes flakiness in the snapshots test. Since the test cannot wait for an indefinite amount of time, this commit removes it in order to not randomly break the CI builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4031.
The title says it all - this PR adds the missing system tests mentioned in the issue description:
Creating / seeking snapshots.⬅️ Removed, because the server only guarantees eventual re-delivery, and a test cannot wait for a fixed amount of time, causes flakiness.