Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: fix Client download_blob_to_file fails #8440

Merged
merged 4 commits into from
Jun 26, 2019
Merged

Storage: fix Client download_blob_to_file fails #8440

merged 4 commits into from
Jun 26, 2019

Conversation

HemangChothani
Copy link
Contributor

Fixes #8301

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2019
@tseaver tseaver added api: storage Issues related to the Cloud Storage API. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 20, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 20, 2019
@tseaver
Copy link
Contributor

tseaver commented Jun 20, 2019

@HemangChothani Please check that unit tests pass with your change: if they do, then we are missing an assertion that the path is passed as expected. Also, please add a system test which exercises this feature (and ensure it passes with your change).

@tseaver tseaver added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 24, 2019
tseaver
tseaver reviewed Jun 24, 2019
View reviewed changes
storage/tests/system.py Outdated Show resolved Hide resolved
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 25, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 25, 2019
tseaver
tseaver suggested changes Jun 25, 2019
View reviewed changes
storage/tests/system.py Outdated Show resolved Hide resolved
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 26, 2019
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 26, 2019
@tseaver
Copy link
Contributor

tseaver commented Jun 26, 2019

Bigtable snippet flakes reported as #8479, #8480.

Firestore systest flake due to #7829.

@tseaver tseaver merged commit a9d9cca into googleapis:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver requested changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage: Client.download_blob_to_file fails.
4 participants
@HemangChothani @tseaver @googlebot @yoshi-kokoro