Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore: Preserve reference to missing documents in 'Client.get_all'. #8472

Merged

Conversation

pchauhan-qlogic
Copy link
Contributor

Fix #7564

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 25, 2019
@pchauhan-qlogic pchauhan-qlogic changed the title Added reference in not exists document in get_all method of client Firestore:Added reference in not exists document in get_all method of client Jun 25, 2019
@tseaver tseaver changed the title Firestore:Added reference in not exists document in get_all method of client Firestore: Preserve reference to missing documents in 'Client.get_all'. Jun 25, 2019
@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Jun 25, 2019
firestore/tests/system.py Outdated Show resolved Hide resolved
firestore/tests/unit/v1/test_client.py Show resolved Hide resolved
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 25, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 25, 2019
@tseaver
Copy link
Contributor

tseaver commented Jun 25, 2019

The Firestore system test failure is due to #7130.

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 26, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 26, 2019
@tseaver
Copy link
Contributor

tseaver commented Jun 26, 2019

Unrelated Bigtable snipped flakiness.

@tseaver tseaver merged commit 83f0262 into googleapis:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firestore: get_all removes .id key for non existing DocumentSnapshot
4 participants