-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage: Blob.exists() does not work within Batch context #8618
Storage: Blob.exists() does not work within Batch context #8618
Conversation
@property | ||
def _is_successfull(self): | ||
"""Checks if binded future request have been completed without any exception.""" | ||
return not isinstance(self._properties, _FutureDict) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If exception have been raised, or request is not done yet, there will be _FutureDict
obj
|
||
--batch_pK7JBAk73-E=_AA5eFwv4m2Q=--""" | ||
) | ||
return mock_conn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are two different responses for two different exists()
calls, and one of them is NotFound
pass | ||
|
||
self.assertFalse(bool1) | ||
self.assertTrue(bool2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking if both exists()
calls working as they suppose to: the first one must be False
(NotFound)
Hi @IlyaFaer, I'm closing this PR as it's focused on a feature request that hasn't been prioritized or has a reviewed design. Please prioritize bugs in the client before feature requests. Thank you for your patience. |
My proposition is to add something like future result - boolean in our case. An object will be working as original
bool
, but under the hood it'll be checking if future response is done without exceptionsTowards: #5388