Storage: Blob.exists() does not work within Batch context #8618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
IlyaFaer
commented
Jul 9, 2019
| @property | ||
| def _is_successfull(self): | ||
| """Checks if binded future request have been completed without any exception.""" | ||
| return not isinstance(self._properties, _FutureDict) |
There was a problem hiding this comment.
If exception have been raised, or request is not done yet, there will be _FutureDict obj
IlyaFaer
commented
Jul 9, 2019
|
|
||
| --batch_pK7JBAk73-E=_AA5eFwv4m2Q=--""" | ||
| ) | ||
| return mock_conn |
There was a problem hiding this comment.
Here are two different responses for two different exists() calls, and one of them is NotFound
IlyaFaer
commented
Jul 9, 2019
| pass | ||
|
|
||
| self.assertFalse(bool1) | ||
| self.assertTrue(bool2) |
There was a problem hiding this comment.
Checking if both exists() calls working as they suppose to: the first one must be False (NotFound)
tseaver
added
api: storage
yoshi-kokoro
removed
the
kokoro:force-run
tseaver
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tseaver
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
AVaksman
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
Hi @IlyaFaer, I'm closing this PR as it's focused on a feature request that hasn't been prioritized or has a reviewed design. Please prioritize bugs in the client before feature requests. Thank you for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My proposition is to add something like future result - boolean in our case. An object will be working as original
bool, but under the hood it'll be checking if future response is done without exceptionsTowards: #5388