Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datacatalog: Add 'search' sample (via synth). #8793

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/datacatalog/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:9aed6bbde54e26d2fcde7aa86d9f64c0278f741e58808c46573e488cbf6098f0
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/datacatalog/artman_datacatalog_v1beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/datacatalog-v1beta1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/datacatalog/v1beta1/timestamps.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/datacatalog-v1beta1/google/cloud/datacatalog_v1beta1/proto/timestamps.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/datacatalog/v1beta1/schema.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/datacatalog-v1beta1/google/cloud/datacatalog_v1beta1/proto/schema.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/datacatalog/v1beta1/tags.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/datacatalog-v1beta1/google/cloud/datacatalog_v1beta1/proto/tags.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/datacatalog/v1beta1/table_spec.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/datacatalog-v1beta1/google/cloud/datacatalog_v1beta1/proto/table_spec.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/datacatalog/v1beta1/search.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/datacatalog-v1beta1/google/cloud/datacatalog_v1beta1/proto/search.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/datacatalog/v1beta1/datacatalog.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/datacatalog-v1beta1/google/cloud/datacatalog_v1beta1/proto/datacatalog.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/datacatalog-v1beta1/google/cloud/datacatalog_v1beta1/proto.
synthtool > Replaced '__doc__ = """Attributes:' in google/cloud/datacatalog_v1beta1/proto/tags_pb2.py.
synthtool > Replaced '__doc__ = """Attributes:' in google/cloud/datacatalog_v1beta1/proto/datacatalog_pb2.py.
.coveragerc
.flake8
MANIFEST.in
noxfile.py.j2
setup.cfg
Running session blacken
Creating virtualenv using python3.6 in .nox/blacken
pip install black==19.3b0
black docs google tests noxfile.py setup.py samples
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/google/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/google/cloud/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/google/cloud/datacatalog.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/google/cloud/datacatalog_v1beta1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/google/cloud/datacatalog_v1beta1/gapic/data_catalog_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/google/cloud/datacatalog_v1beta1/gapic/transports/data_catalog_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/google/cloud/datacatalog_v1beta1/proto/schema_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/google/cloud/datacatalog_v1beta1/proto/schema_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/google/cloud/datacatalog_v1beta1/proto/datacatalog_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/google/cloud/datacatalog_v1beta1/proto/search_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/google/cloud/datacatalog_v1beta1/proto/search_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/google/cloud/datacatalog_v1beta1/proto/table_spec_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/google/cloud/datacatalog_v1beta1/proto/table_spec_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/google/cloud/datacatalog_v1beta1/proto/tags_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/google/cloud/datacatalog_v1beta1/proto/timestamps_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/google/cloud/datacatalog_v1beta1/proto/timestamps_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/google/cloud/datacatalog_v1beta1/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/google/cloud/datacatalog_v1beta1/gapic/data_catalog_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/samples/v1beta1/datacatalog_get_entry.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/samples/v1beta1/datacatalog_lookup_entry.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/noxfile.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/samples/v1beta1/datacatalog_lookup_entry_sql_resource.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/samples/v1beta1/datacatalog_search.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/google/cloud/datacatalog_v1beta1/proto/tags_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/google/cloud/datacatalog_v1beta1/proto/datacatalog_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/datacatalog/tests/unit/gapic/v1beta1/test_data_catalog_client_v1beta1.py
All done! ✨ 🍰 ✨
26 files reformatted, 6 files left unchanged.
Session blacken was successful.
synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: datacatalog Issues related to the Data Catalog API. label Jul 26, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 26, 2019
@tseaver tseaver changed the title [CHANGE ME] Re-generated datacatalog to pick up changes in the API or client library generator. Datacatalog: Add 'search' sample (via synth). Jul 26, 2019
@tseaver
Copy link
Contributor

tseaver commented Jul 26, 2019

Monitoring and Security Center "failures" show synth output, not tests.

@tseaver
Copy link
Contributor

tseaver commented Jul 26, 2019

@busunkim96 Nothing actually tests the generated samples, but since we have other untested ones, it doesn't seem like a blocker here.

@ghost
Copy link

ghost commented Jul 26, 2019

@tseaver, the generated samples may be tested by sample-tester, based on YAML files available at https://github.com/googleapis/googleapis/tree/master/google/cloud/datacatalog/v1beta1/samples.

@tseaver
Copy link
Contributor

tseaver commented Jul 26, 2019

@ricardosm-cit Where would failures be reported by samples-tester?

@ghost
Copy link

ghost commented Jul 26, 2019

Sorry @tseaver, I don't know. Maybe @busunkim96 can help with this.

@busunkim96
Copy link
Contributor

I just talked to Rebecca -- it sounds like the sample-tester isn't quite ready. Synthtool will be updated to run sample tests using sample-tester soon. We can leaves these untested for the time being.

@busunkim96 busunkim96 merged commit 2ff1073 into master Jul 26, 2019
parthea pushed a commit that referenced this pull request Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datacatalog Issues related to the Data Catalog API. cla: yes This human has signed the Contributor License Agreement. codegen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants