BigQuery: Add support for unsetting LoadJobConfig schema #9077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
plamut
commented
Aug 22, 2019
|
|
||
| config.schema = None | ||
| self.assertNotIn("schema", config._properties["load"]) | ||
| config.schema = None # no error, idempotent operation |
There was a problem hiding this comment.
This extra assignment is to catch fragile implementations such as
del self._properties["load"]["schema"]
(nope, did not do it myself, but I've seen similar bugs in the past 😆 )
tswast
approved these changes
Aug 22, 2019
HemangChothani
pushed a commit
to HemangChothani/google-cloud-python
that referenced
this pull request
Aug 29, 2019
emar-kar
pushed a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9074.
This PR adds a public way of unsetting a schema from a
LoadJobConfig.How to test
Create a
LoadJobConfigwith aschemaattribute, then setschematoNone--> the schema should be cleared.